refactor: add param files in planning module #3363
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
This reverts commit 6cd13f8. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
kosuke55,
mkuri,
soblin,
maxime-clem,
satoshi-ota,
shmpwk,
taikitanaka3,
takayuki5168,
TomohitoAndo,
tkimura4,
purewater0901,
a team,
rej55,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
- Coverage 12.33% 12.20% -0.14%
==========================================
Files 1378 1381 +3
Lines 96606 97663 +1057
Branches 27926 28817 +891
==========================================
+ Hits 11917 11918 +1
- Misses 72058 72962 +904
- Partials 12631 12783 +152
*This pull request uses carry forward flags. Click here to find out more. see 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -6,6 +6,8 @@ | |||
| resample_interval_for_output: 4.0 # [m] | |||
| detection_area_right_expand_dist: 0.0 # [m] | |||
| detection_area_left_expand_dist: 1.0 # [m] | |||
| drivable_area_right_bound_offset: 0.0 # [m] | |||
| drivable_area_left_bound_offset: 0.0 # [m] | |||
There was a problem hiding this comment.
It already exists in the other config file.
There was a problem hiding this comment.
Thank you for checking!
But in launcher side same parameters exist. Launcher side should be deleted?
There was a problem hiding this comment.
Yes, I think we should remove both side parameters.
There was a problem hiding this comment.
I understand!
Deleted params in avoidance.param.yaml
| rear_vehicle_safety_time_margin: 2.0 | ||
| rear_vehicle_safety_time_margin: 1.0 | ||
|
|
||
| # USE ONLY WHEN THE OPTION COMPILE_WITH_OLD_ARCHITECTURE IS SET TO FALSE. |
There was a problem hiding this comment.
[imo] It is better to separate these params to another file like autoware_launch config.
There was a problem hiding this comment.
Deleted parameters.
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
| @@ -1,6 +1,7 @@ | |||
| /**: | |||
| ros__parameters: | |||
| pull_over: | |||
| request_length: 100.0 | |||
There was a problem hiding this comment.
oh, sorry for missing checking.
some parameters are not in the launcher config.
https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/pull_over/pull_over.param.yaml
Description
Modify and add parameter files to match launcher repository. This is necessary for retrieving parameters when launching nodes for testing within each package.
Tests performed
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.