Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(planning_evaluator): add dependency #3388

Merged
merged 1 commit into from
Apr 13, 2023
Merged

chore(planning_evaluator): add dependency #3388

merged 1 commit into from
Apr 13, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Apr 13, 2023 •
edited
Loading

Description

Add exec_depend of tier4_planning_launch to planning_evaluator.
The planning evaluator is called here

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tkimura4
chore(planning_evaluator): add dependency
838fef1 
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 13, 2023
kyoichi-sugahara
kyoichi-sugahara approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(and sorry formissing...)

@tkimura4 tkimura4 enabled auto-merge (squash) April 13, 2023 07:56
@tkimura4 tkimura4 merged commit 3310854 into autowarefoundation:main Apr 13, 2023
@tkimura4 tkimura4 deleted the chore/add_dependency branch April 13, 2023 08:01
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@purewater0901 purewater0901 Awaiting requested review from purewater0901

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkimura4 @kyoichi-sugahara