Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avoidance): separate debug marker namespace for each ignore reason #3507

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 24, 2023

Description

separate debug marker namespace for each ignore reason in order to show only objects which we want to see.

rviz_screenshot_2023_04_24-10_06_44

Screenshot from 2023-04-24 10-07-04

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4af956b) 13.81% compared to head (b62b0f6) 13.82%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3507    +/-   ##
========================================
  Coverage   13.81%   13.82%            
========================================
  Files        1391     1391            
  Lines       97512    97612   +100     
  Branches    28871    28953    +82     
========================================
+ Hits        13469    13490    +21     
- Misses      69560    69621    +61     
- Partials    14483    14501    +18     
Flag Coverage Δ *Carryforward flag
differential 12.32% <0.00%> (?)
total 13.81% <ø> (+<0.01%) ⬆️ Carriedforward from 4af956b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r_path_planner/src/marker_util/avoidance/debug.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.35% <0.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 784919d into autowarefoundation:main Apr 24, 2023
@satoshi-ota satoshi-ota deleted the feat/separate-namespace branch April 24, 2023 09:48
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…on (autowarefoundation#3507)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants