Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unused <depend> in package.xml files #3606

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

VRichardJP
Copy link
Contributor

@VRichardJP VRichardJP commented May 2, 2023

Description

Cleaned all unused <depend> reported by the ad-hoc unused_deps.sh script.

In most cases, removing the <depend> line is enough. But sometimes downstream packages are impacted and must add the missing dependency.
Sometimes <depend> are just <build_depend> or <test_depend>.

Related links

autowarefoundation/autoware#3468

Tests performed

Can compile with tests and run demo with the planning simulator.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda
Copy link
Contributor

kminoda commented Oct 12, 2023

@VRichardJP Understood, thank you! Would you mind making this PR as a draft?

@VRichardJP VRichardJP marked this pull request as draft October 12, 2023 00:36
Copy link

stale bot commented Dec 11, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:system System design and integration. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.