-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): use pluginlib #3734
refactor(behavior_velocity_planner): use pluginlib #3734
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3734 +/- ##
==========================================
- Coverage 14.51% 13.81% -0.71%
==========================================
Files 1442 1526 +84
Lines 101582 107645 +6063
Branches 30204 30465 +261
==========================================
+ Hits 14747 14867 +120
- Misses 70691 76705 +6014
+ Partials 16144 16073 -71
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(checked with scenario tests tier4 internal slack)
cc. @mitsudome-r @xmfcx @mehmetdogru This PR changes the package structure in Planning. Please see the background in issue #3724 |
…n#3734) * feat: move interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move utilization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add plugin loader Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use plugin interface for all scene module Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove debug code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update package dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move crosswalk Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add template package Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move intersection Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move traffic light Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move blind spot Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move detection area Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move no stopping area Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move occlusion spot Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move occlusion spot test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move out of lane Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move run out Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move speed bump and virtual traffic light Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * move: common test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…n#3734) (#509) * refactor(behavior_velocity_planner): use pluginlib (autowarefoundation#3734) * feat: move interface Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move utilization Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add plugin loader Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: use plugin interface for all scene module Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: remove debug code Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: update package dependency Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move crosswalk Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: add template package Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move intersection Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move traffic light Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move blind spot Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move detection area Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move no stopping area Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move occlusion spot Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move occlusion spot test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move out of lane Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move run out Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * feat: move speed bump and virtual traffic light Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * move: common test Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * apply Kimura-san's patch Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add find_package pcl explicitly Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Description
Split behavior_velocity_planner scene module into an independent package by using pluginlib. See #3724 for details. This PR focuses on splitting the package, so no documentation or parameter files have changed. These will be covered in other PRs.
Related links
#3724
TIER IV INTERNAL LINK
Tests performed
Notes for reviewers
I split the package.xml file, so please check the maintainer, author, and depend tags.
Interface changes
None
Effects on system behavior
None (It should not be affected)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.