Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): use pluginlib #3734

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 17, 2023

Description

Split behavior_velocity_planner scene module into an independent package by using pluginlib. See #3724 for details. This PR focuses on splitting the package, so no documentation or parameter files have changed. These will be covered in other PRs.

Related links

#3724
TIER IV INTERNAL LINK

Tests performed

  • Check autonomous driving in simple planning simulator.
  • Check scenarios in scenario simulator.

Notes for reviewers

I split the package.xml file, so please check the maintainer, author, and depend tags.

Interface changes

None

Effects on system behavior

None (It should not be affected)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 17, 2023
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 39.39% and project coverage change: -0.71 ⚠️

Comparison is base (c16ba06) 14.51% compared to head (6a98224) 13.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
- Coverage   14.51%   13.81%   -0.71%     
==========================================
  Files        1442     1526      +84     
  Lines      101582   107645    +6063     
  Branches    30204    30465     +261     
==========================================
+ Hits        14747    14867     +120     
- Misses      70691    76705    +6014     
+ Partials    16144    16073      -71     
Flag Coverage Δ *Carryforward flag
differential 5.04% <39.39%> (?)
total 14.48% <ø> (-0.04%) ⬇️ Carriedforward from bff1a84

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../behavior_velocity_blind_spot_module/src/debug.cpp 0.00% <ø> (ø)
...ehavior_velocity_blind_spot_module/src/manager.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_blind_spot_module/src/manager.hpp 0.00% <0.00%> (ø)
.../behavior_velocity_blind_spot_module/src/scene.cpp 0.00% <ø> (ø)
.../behavior_velocity_blind_spot_module/src/scene.hpp 0.00% <ø> (ø)
...g/behavior_velocity_crosswalk_module/src/debug.cpp 0.00% <ø> (ø)
...behavior_velocity_crosswalk_module/src/manager.cpp 0.00% <0.00%> (ø)
...behavior_velocity_crosswalk_module/src/manager.hpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <ø> (ø)
...or_velocity_crosswalk_module/src/scene_walkway.cpp 0.00% <ø> (ø)
... and 86 more

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi marked this pull request as ready for review May 18, 2023 00:37
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(checked with scenario tests tier4 internal slack)

@TakaHoribe
Copy link
Contributor

cc. @mitsudome-r @xmfcx @mehmetdogru This PR changes the package structure in Planning. Please see the background in issue #3724

@isamu-takagi isamu-takagi enabled auto-merge (squash) May 22, 2023 00:16
@isamu-takagi isamu-takagi self-assigned this May 22, 2023
@isamu-takagi isamu-takagi merged commit eabacd7 into autowarefoundation:main May 22, 2023
@isamu-takagi isamu-takagi deleted the refactor/behavior-velocity-planner-plugin branch May 22, 2023 02:28
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request May 23, 2023
…n#3734)

* feat: move interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move utilization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add plugin loader

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: use plugin interface for all scene module

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: remove debug code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: update package dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move crosswalk

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add template package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move intersection

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move traffic light

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move blind spot

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move detection area

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move no stopping area

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move occlusion spot

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move occlusion spot test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move out of lane

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move run out

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move speed bump and virtual traffic light

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* move: common test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 24, 2023
…n#3734) (#509)

* refactor(behavior_velocity_planner): use pluginlib (autowarefoundation#3734)

* feat: move interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move utilization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add plugin loader

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: use plugin interface for all scene module

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: remove debug code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: update package dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move crosswalk

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add template package

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move intersection

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move traffic light

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move blind spot

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move detection area

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move no stopping area

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move occlusion spot

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move occlusion spot test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move out of lane

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move run out

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move speed bump and virtual traffic light

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* move: common test

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* apply Kimura-san's patch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add find_package pcl explicitly

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants