Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_adapi_rviz_plugin): add route panel #3840

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 26, 2023

Description

Add the route panel to set a route with options.

Tests performed

simplescreenrecorder-2023-05-26_18.47.34.mp4

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned) labels May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (358d4a7) 14.09% compared to head (5e77cf5) 14.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3840      +/-   ##
==========================================
- Coverage   14.09%   14.08%   -0.01%     
==========================================
  Files        1438     1439       +1     
  Lines      101620   101691      +71     
  Branches    27045    27045              
==========================================
  Hits        14328    14328              
- Misses      71607    71678      +71     
  Partials    15685    15685              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.09% <ø> (ø) Carriedforward from 9c7e47d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/tier4_adapi_rviz_plugin/src/route_panel.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this May 26, 2023
@isamu-takagi isamu-takagi marked this pull request as ready for review May 26, 2023 09:51
@isamu-takagi isamu-takagi requested review from h-ohta, kosuke55 and a team as code owners May 26, 2023 09:51
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isamu-takagi isamu-takagi merged commit 4e45188 into autowarefoundation:main May 29, 2023
@isamu-takagi isamu-takagi deleted the feat/add-route-panel branch May 29, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants