fix(map_loader): handle enable_selected_load correctly

[kminoda]

Description

The previous implementation did not consider a case where enable_partial_load and enable_differential_load is set false but enable_selected_load is set true.

Related links

None

Tests performed

Launch with following config before and after PR, and confirmed that the selected node client launches successfully after the PR while not before.

/**:
  ros__parameters:
    enable_whole_load: true
    enable_downsampled_whole_load: false
    enable_partial_load: false
    enable_differential_load: false
    enable_selected_load: true

    # only used when downsample_whole_load enabled
    leaf_size: 3.0 # downsample leaf size [m]

Notes for reviewers

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[Shin-kyoto]

LGTM

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (35bc65a) 14.05% compared to head (e3567c4) 14.05%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3920   +/-   ##
=======================================
  Coverage   14.05%   14.05%           
=======================================
  Files        1456     1456           
  Lines      102521   102521           
  Branches    27295    27295           
=======================================
  Hits        14411    14411           
  Misses      72323    72323           
  Partials    15787    15787           

Flag	Coverage Δ		*Carryforward flag
differential	26.34% <0.00%> (?)
total	14.05% <ø> (+<0.01%)	⬆️	Carriedforward from 994728f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...intcloud_map_loader/pointcloud_map_loader_node.cpp	1.69% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[RyuYamamoto]

LGTM