Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): unable to fix bound #3942

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jun 12, 2023

Description

Unable to fix lane boundary for avoid bug.
Fix bug is a future work.

Tests performed

TIER IV INTERNAL LINK

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.00 ⚠️

Comparison is base (8898417) 15.44% compared to head (a679ef8) 14.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3942      +/-   ##
==========================================
- Coverage   15.44%   14.45%   -1.00%     
==========================================
  Files        1350     1456     +106     
  Lines       95929   102535    +6606     
  Branches    29719    29720       +1     
==========================================
+ Hits        14818    14820       +2     
- Misses      64952    71558    +6606     
+ Partials    16159    16157       -2     
Flag Coverage Δ *Carryforward flag
differential 12.85% <0.00%> (?)
total 14.45% <ø> (-1.00%) ⬇️ Carriedforward from 59b1006

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 17.08% <0.00%> (-0.02%) ⬇️

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 463d4e2 into autowarefoundation:main Jun 13, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 13, 2023
)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
1222-takeshi added a commit to tier4/autoware.universe that referenced this pull request Jun 13, 2023
) (#575)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 deleted the fix/unable_bound_fix branch December 8, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants