Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lane_change): don't exit for danger param #4092

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 27, 2023

Description

The program will not be terminated with a danger parameter.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 27, 2023
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6f5af96) 14.35% compared to head (5eb8b9f) 14.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4092      +/-   ##
==========================================
- Coverage   14.35%   14.35%   -0.01%     
==========================================
  Files        1567     1567              
  Lines      107849   107852       +3     
  Branches    31231    31234       +3     
==========================================
  Hits        15487    15487              
- Misses      75522    75524       +2     
- Partials    16840    16841       +1     
Flag Coverage Δ *Carryforward flag
differential 13.57% <0.00%> (?)
total 14.36% <ø> (+<0.01%) ⬆️ Carriedforward from 6f5af96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.31% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.81% <0.00%> (-0.01%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 15.29% <0.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the lc-remove-terminate branch from 10d12fa to 5eb8b9f Compare June 27, 2023 11:07
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 27, 2023
@TakaHoribe TakaHoribe merged commit 0443a08 into autowarefoundation:main Jun 27, 2023
@TakaHoribe TakaHoribe deleted the lc-remove-terminate branch June 27, 2023 13:47
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2023
)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants