Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): add function to visualize drivable lanes #4282

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 14, 2023

Description

🤖 Generated by Copilot at 051fd0c

Added a new function createDrivableLanesMarkerArray to the debug_utilities namespace, which creates and returns a marker array message for visualizing the drivable lanes in the behavior path planner. Modified the files debug_utilities.hpp and debug_utilities.cpp to implement this function.

  • RED : RIGHT LANE
  • GREEN : LEFT LANE
  • BLUE : MIDDLE LANE(s)

Screenshot from 2023-07-14 13-00-30

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 14, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review July 14, 2023 06:52
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dc29d01) 15.19% compared to head (fc1b0d0) 15.19%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4282    +/-   ##
========================================
  Coverage   15.19%   15.19%            
========================================
  Files        1491     1491            
  Lines      102790   103769   +979     
  Branches    31543    32241   +698     
========================================
+ Hits        15617    15766   +149     
- Misses      70214    70878   +664     
- Partials    16959    17125   +166     
Flag Coverage Δ *Carryforward flag
differential 13.55% <0.00%> (?)
total 15.19% <ø> (ø) Carriedforward from 8a9de78

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...avior_path_planner/marker_util/debug_utilities.hpp 0.00% <ø> (ø)
...r_path_planner/src/marker_util/debug_utilities.cpp 9.89% <0.00%> (-1.16%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the feat/drivable-lanes-marker branch from 051fd0c to 8a9de78 Compare July 18, 2023 00:40
@satoshi-ota
Copy link
Contributor Author

@zulfaqar-azmi-t4 I'd like to make it possible to output drivable lanes debug marker from planner manager. So, I added a util funciton to create debug marker. I think you sometimes analyze drivable lanes issue, do you have any ideas what we want to see?

@zulfaqar-azmi-t4
Copy link
Contributor

@satoshi-ota
This is super helpful.
Normally it will observe the following

  1. drivable lanes of each specific modules (not combined)
  2. previous module drivable area with reference to current module.

There are also the overlapped and non overlapping drivable lanes, but i think the above 2 is the most crucial ones.

@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Jul 18, 2023

@zulfaqar-azmi-t4 Thanks for your comment 👍

drivable lanes of each specific modules (not combined)
previous module drivable area with reference to current module.

Then, I'll add interface to output drivable lanes info from each modules in other PR. 👍 So, could you review this PR at first?

….cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
….cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 self-requested a review July 20, 2023 05:37
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@satoshi-ota
Copy link
Contributor Author

@zulfaqar-azmi-t4 Thanks for your suggestions 👍 I'll add interface & improve implementation in other PR.

@satoshi-ota satoshi-ota enabled auto-merge (squash) July 20, 2023 05:43
@satoshi-ota satoshi-ota merged commit a0914e7 into autowarefoundation:main Jul 20, 2023
@satoshi-ota satoshi-ota deleted the feat/drivable-lanes-marker branch July 20, 2023 06:50
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
…tion#4282)

* feat(utils): add function to visualize drivable lanes

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* Update planning/behavior_path_planner/src/marker_util/debug_utilities.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* Update planning/behavior_path_planner/src/marker_util/debug_utilities.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants