-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(utils): add function to visualize drivable lanes #4282
feat(utils): add function to visualize drivable lanes #4282
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4282 +/- ##
========================================
Coverage 15.19% 15.19%
========================================
Files 1491 1491
Lines 102790 103769 +979
Branches 31543 32241 +698
========================================
+ Hits 15617 15766 +149
- Misses 70214 70878 +664
- Partials 16959 17125 +166
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
051fd0c
to
8a9de78
Compare
@zulfaqar-azmi-t4 I'd like to make it possible to output drivable lanes debug marker from planner manager. So, I added a util funciton to create debug marker. I think you sometimes analyze drivable lanes issue, do you have any ideas what we want to see? |
@satoshi-ota
There are also the overlapped and non overlapping drivable lanes, but i think the above 2 is the most crucial ones. |
@zulfaqar-azmi-t4 Thanks for your comment 👍
Then, I'll add interface to output drivable lanes info from each modules in other PR. 👍 So, could you review this PR at first? |
planning/behavior_path_planner/src/marker_util/debug_utilities.cpp
Outdated
Show resolved
Hide resolved
….cpp Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
planning/behavior_path_planner/src/marker_util/debug_utilities.cpp
Outdated
Show resolved
Hide resolved
….cpp Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@zulfaqar-azmi-t4 Thanks for your suggestions 👍 I'll add interface & improve implementation in other PR. |
…tion#4282) * feat(utils): add function to visualize drivable lanes Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * Update planning/behavior_path_planner/src/marker_util/debug_utilities.cpp Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> * Update planning/behavior_path_planner/src/marker_util/debug_utilities.cpp Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Description
🤖 Generated by Copilot at 051fd0c
Added a new function
createDrivableLanesMarkerArray
to thedebug_utilities
namespace, which creates and returns a marker array message for visualizing the drivable lanes in the behavior path planner. Modified the filesdebug_utilities.hpp
anddebug_utilities.cpp
to implement this function.Tests performed
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.