refactor(ndt_scan_matcher): fixed as pointed out by clang-tidy

[SakodaShintaro]

Description

All .hpp and .cpp files under the ndt_scan_matcher package have been modified as pointed out by clang-tidy.

The confirmed commands is:

fdfind -e cpp -e hpp --full-path "./src/universe/autoware.universe/localization/ndt_scan_matcher/" | xargs -P $(nproc) -I{} clang-tidy -p build/ {}

Tests performed

I have checked the operation of the following three

• logging_simulator
• driving_log_replayer
• awsim

I have tried both true and false flags for use_dynamic_map_loading.

Effects on system behavior

There are no changes about behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (f72b71b) 14.93% compared to head (ea1637c) 14.93%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4286   +/-   ##
=======================================
  Coverage   14.93%   14.93%           
=======================================
  Files        1515     1515           
  Lines      104546   104544    -2     
  Branches    31779    31779           
=======================================
  Hits        15615    15615           
+ Misses      71895    71893    -2     
  Partials    17036    17036           

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	14.93% <ø> (+<0.01%)	⬆️	Carriedforward from f72b71b

*This pull request uses carry forward flags. Click here to find out more.

Files Changed	Coverage Δ
localization/ndt_scan_matcher/src/debug.cpp	0.00% <0.00%> (ø)
localization/ndt_scan_matcher/src/map_module.cpp	0.00% <0.00%> (ø)
...ization/ndt_scan_matcher/src/map_update_module.cpp	0.00% <0.00%> (ø)
...n/ndt_scan_matcher/src/pose_array_interpolator.cpp	0.00% <0.00%> (ø)
localization/ndt_scan_matcher/src/util_func.cpp	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kminoda]

LGTM
Confirmed that the PR works with the sample map & rosbag (both original and split version map)

[SakodaShintaro]

Thank you for your review.
I confirmed both original and split version map.