Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): update build-and-test-differential to use self hosted runners #4364

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 21, 2023

Description

They are failing due to lack of disk space.

@mitsudome-r said:

Regarding the failure is happening when it is downloading the docker size which is about 16 GB.
However, GitHub only guarantee 14 GB according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ed runners

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 21, 2023
@xmfcx xmfcx requested a review from mitsudome-r July 21, 2023 15:28
@xmfcx xmfcx self-assigned this Jul 21, 2023
@mitsudome-r
Copy link
Member

mitsudome-r commented Jul 21, 2023

@xmfcx Thanks for the PR.
Don't we also have to change the following line since it uses the same docker container ghcr.io/autowarefoundation/autoware-universe:humble-latest-cuda?

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx
Copy link
Contributor Author

xmfcx commented Jul 21, 2023

Thanks for noticing, updated it with 120fe51

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xmfcx xmfcx enabled auto-merge (squash) July 21, 2023 15:52
@xmfcx xmfcx merged commit 0e07aa8 into main Jul 21, 2023
@xmfcx xmfcx deleted the chore/use-self-hosted branch July 21, 2023 16:19
@HansRobo
Copy link
Member

HansRobo commented Jul 22, 2023

Mitsudome-san added a workflow execution guard to avoid running self-hosted-runner by outsider!

#4368

@shmpwk shmpwk mentioned this pull request Jul 22, 2023
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jul 24, 2023
…ed runners (autowarefoundation#4364)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants