refactor(safety_checker): remove lane change dependency #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
component:planning
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
satoshi-ota
added
the
run:build-and-test-differential
planning/behavior_path_planner/include/behavior_path_planner/utils/safety_check.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kyoichi-sugahara
approved these changes
Jul 25, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 15.01% 15.01%
=======================================
Files 1508 1509 +1
Lines 104000 104000
Branches 31768 31768
=======================================
Hits 15615 15615
Misses 71349 71349
Partials 17036 17036
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 7, 2023
…dation#4387) * refactor(safety_checker): remove lane change dependency Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(safety_checker): init primitive member variables Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 019b492
This pull request refactors the safety check related structs and their include dependencies in the behavior path planner component. It moves the struct definitions from
lane_change_module_data.hpptosafety_check.hpp, and updates the type aliases andusingdeclarations accordingly. This improves the code organization, readability, and modularity.Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.