feat(yabloc): change namespace #4389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
kminoda
requested review from
KYabuuchi,
isamu-takagi,
YamatoAndo and
RyuYamamoto
as code owners
github-actions
bot
added
component:localization
kminoda
added
the
run:build-and-test-differential
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4389 +/- ##
=======================================
Coverage 15.01% 15.01%
=======================================
Files 1508 1508
Lines 103991 103991
Branches 31764 31764
=======================================
Hits 15615 15615
Misses 71341 71341
Partials 17035 17035
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KYabuuchi
approved these changes
Jul 25, 2023
|
@YamatoAndo @isamu-takagi Could you review this PR? 🙏 |
isamu-takagi
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update yabloc namespace
Before:
/localization/pose_estimator/...After:
/localization/pose_estimator/yabloc/...This is a step towards a unified namespace representation of localization methods in Autoware.
Related links
N/A
Tests performed
I used sample YabLoc data and tested it in logging simulator, confirmed that the localization works including the pose initialization.
Notes for reviewers
N/A
Interface changes
Yes.
As noted above, this PR adds
yablocnamespace in all the interface related to YabLoc.We argue that this influence is limited since YabLoc has just recently been merged.
Effects on system behavior
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.