Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yabloc): replace deprecated rosidl API #4423

Merged

Conversation

f0reachARR
Copy link
Contributor

Description

From ROS 2 humble, rosidl_target_interfaces is deprecated: ref. ros2/rosidl#606
Some packages adapt this changes by using rosidl_get_typesupport_target + version checking like this, but yabloc does not.

This PR introduce rosidl_get_typesupport_target + version checking to yabloc packages.

Tests performed

Not applicable for behavior. Build succeeded.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: f0reachARR <f0reach@f0reach.me>
@f0reachARR f0reachARR requested a review from KYabuuchi as a code owner July 27, 2023 08:05
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Jul 27, 2023
@KYabuuchi KYabuuchi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 27, 2023
@HansRobo HansRobo enabled auto-merge (squash) July 27, 2023 08:23
@KYabuuchi
Copy link
Contributor

Thank you for your contribution! I really appreciate it. 😄
This PR looks good to me.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3113539) 14.92% compared to head (f67d160) 14.92%.
Report is 6 commits behind head on main.

❗ Current head f67d160 differs from pull request most recent head 52d9163. Consider uploading reports for the commit 52d9163 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4423   +/-   ##
=======================================
  Coverage   14.92%   14.92%           
=======================================
  Files        1515     1515           
  Lines      104511   104490   -21     
  Branches    31773    31768    -5     
=======================================
  Hits        15595    15595           
+ Misses      71902    71881   -21     
  Partials    17014    17014           
Flag Coverage Δ *Carryforward flag
differential 8.37% <ø> (?)
total 14.92% <ø> (+<0.01%) ⬆️ Carriedforward from 3113539

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% <ø> (ø)
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.hpp 25.00% <ø> (+5.00%) ⬆️
...th_planner/scene_module/scene_module_interface.hpp 17.79% <ø> (+1.12%) ⬆️
...nner/scene_module/side_shift/side_shift_module.hpp 0.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.10% <ø> (+0.01%) ⬆️
...cene_module/start_planner/start_planner_module.cpp 4.21% <ø> (+0.01%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HansRobo HansRobo merged commit 917ead5 into autowarefoundation:main Jul 27, 2023
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Jul 29, 2023
)

* refactor(yabloc_particle_filter): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

* refactor(yabloc_pose_initializer): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

---------

Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 5, 2023
)

* refactor(yabloc_particle_filter): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

* refactor(yabloc_pose_initializer): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

---------

Signed-off-by: f0reachARR <f0reach@f0reach.me>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
)

* refactor(yabloc_particle_filter): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

* refactor(yabloc_pose_initializer): remove deprecated cmake ros2idl API

Signed-off-by: f0reachARR <f0reach@f0reach.me>

---------

Signed-off-by: f0reachARR <f0reach@f0reach.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants