-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(yabloc): replace deprecated rosidl API #4423
refactor(yabloc): replace deprecated rosidl API #4423
Conversation
Signed-off-by: f0reachARR <f0reach@f0reach.me>
Signed-off-by: f0reachARR <f0reach@f0reach.me>
Thank you for your contribution! I really appreciate it. 😄 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
=======================================
Coverage 14.92% 14.92%
=======================================
Files 1515 1515
Lines 104511 104490 -21
Branches 31773 31768 -5
=======================================
Hits 15595 15595
+ Misses 71902 71881 -21
Partials 17014 17014
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
) * refactor(yabloc_particle_filter): remove deprecated cmake ros2idl API Signed-off-by: f0reachARR <f0reach@f0reach.me> * refactor(yabloc_pose_initializer): remove deprecated cmake ros2idl API Signed-off-by: f0reachARR <f0reach@f0reach.me> --------- Signed-off-by: f0reachARR <f0reach@f0reach.me> Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
From ROS 2 humble,
rosidl_target_interfaces
is deprecated: ref. ros2/rosidl#606Some packages adapt this changes by using
rosidl_get_typesupport_target
+ version checking like this, but yabloc does not.This PR introduce
rosidl_get_typesupport_target
+ version checking to yabloc packages.Tests performed
Not applicable for behavior. Build succeeded.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.