fix(traffic_light_occlusion_predictor): bug fix #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
github-actions
bot
added
the
component:perception
shmpwk
added
the
run:build-and-test-differential
miursh
approved these changes
Jul 27, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
==========================================
- Coverage 14.92% 14.92% -0.01%
==========================================
Files 1515 1515
Lines 104509 104507 -2
Branches 31773 31773
==========================================
- Hits 15595 15594 -1
+ Misses 71900 71899 -1
Partials 17014 17014
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
7 tasks
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 28, 2023
* fix(image_projection_based_fusion): revert the swap of postprocess and publish (autowarefoundation#4400) fix: revert the swap of postprocess and publish Signed-off-by: tzhong518 <sworgun@gmail.com> * fix(image_projection_based_fusion): fix pointpainting error caused by empty pointcloud (autowarefoundation#4427) * fix(image_projection_based_fusion): fix pointpainting error caused by empty pointcloud Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(traffic_light_occlusion_predictor): bug fix (autowarefoundation#4426) fix traffic_light_occlusion_predictor bug Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> --------- Signed-off-by: tzhong518 <sworgun@gmail.com> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Co-authored-by: Tao Zhong <55872497+tzhong518@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mingyu1991 <115005477+Mingyu1991@users.noreply.github.com>
TomohitoAndo
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 21, 2023
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 21, 2023
) (#752) fix traffic_light_occlusion_predictor bug Signed-off-by: Mingyu Li <mingyu.li@tier4.jp> Co-authored-by: Mingyu1991 <115005477+Mingyu1991@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Considering in_roi_msg could be nullptr, it would cause break down when it's called
Tests performed
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.