-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traffic_light_arbiter): publish traffic light info even when a map without traffic lights is subscribed #4428
fix(traffic_light_arbiter): publish traffic light info even when a map without traffic lights is subscribed #4428
Conversation
…p without traffic lights is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
=======================================
Coverage 14.92% 14.92%
=======================================
Files 1515 1515
Lines 104509 104491 -18
Branches 31773 31772 -1
=======================================
- Hits 15595 15594 -1
+ Misses 71900 71884 -16
+ Partials 17014 17013 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
perception/traffic_light_arbiter/include/traffic_light_arbiter/traffic_light_arbiter.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Tested it using the data from 2023-04-17-17-44-15
.
Only one nit: shared_ptr -> unique_ptr as the data is not being shared
4b2692e
to
9b69d4d
Compare
…/traffic_light_arbiter.hpp Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@knzo25 |
…p without traffic lights is subscribed (autowarefoundation#4428) * fix(traffic_light_arbiter): publish traffic light info even when a map without traffic lights is subscribed Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * feat: publish empty message if the size of elemsents_set is 0 Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * Update perception/traffic_light_arbiter/include/traffic_light_arbiter/traffic_light_arbiter.hpp Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/traffic_light_arbiter/src/traffic_light_arbiter.cpp Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp> --------- Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Description
publish traffic light info even when a map without traffic lights is subscribed
Tests performed
I tested as below.
publish map without traffic lights
publish /external/traffic_light_recognition/traffic_signals
Effects on system behavior
Even when you use a map without traffic light, traffic_light_arbiter will publish traffic light info.
( When you use a map with traffic light, this PR has no effects on system behavior. )
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.