Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light_arbiter): publish traffic light info even when a map without traffic lights is subscribed #4428

Merged

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jul 27, 2023

Description

publish traffic light info even when a map without traffic lights is subscribed

Tests performed

I tested as below.

  • launch traffic_light_arbiter
$ros2 launch traffic_light_arbiter traffic_light_arbiter.launch.xml 
  • publish map without traffic lights

  • publish /external/traffic_light_recognition/traffic_signals

$ros2 topic pub /external/traffic_light_recognition/traffic_signals autoware_perception_msgs/msg/TrafficSignalArray {}
  • confirm that traffic_signals messages are published by traffic_light_arbiter
$ ros2 topic echo /perception/traffic_light_arbiter/traffic_signals

Effects on system behavior

Even when you use a map without traffic light, traffic_light_arbiter will publish traffic light info.
( When you use a map with traffic light, this PR has no effects on system behavior. )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…p without traffic lights is subscribed

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from shmpwk July 27, 2023 13:25
@tkimura4 tkimura4 requested a review from knzo25 as a code owner July 27, 2023 13:25
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 27, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f6fdce) 14.92% compared to head (9b69d4d) 14.92%.
Report is 9 commits behind head on main.

❗ Current head 9b69d4d differs from pull request most recent head cbceb8e. Consider uploading reports for the commit cbceb8e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4428   +/-   ##
=======================================
  Coverage   14.92%   14.92%           
=======================================
  Files        1515     1515           
  Lines      104509   104491   -18     
  Branches    31773    31772    -1     
=======================================
- Hits        15595    15594    -1     
+ Misses      71900    71884   -16     
+ Partials    17014    17013    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.92% <ø> (+<0.01%) ⬆️ Carriedforward from 9f6fdce

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
localization/ndt_scan_matcher/src/debug.cpp 0.00% <ø> (ø)
localization/ndt_scan_matcher/src/map_module.cpp 0.00% <ø> (ø)
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% <ø> (ø)
...n/ndt_scan_matcher/src/pose_array_interpolator.cpp 0.00% <ø> (ø)
localization/ndt_scan_matcher/src/util_func.cpp 0.00% <ø> (ø)
...raffic_light_arbiter/src/traffic_light_arbiter.cpp 0.00% <0.00%> (ø)
..._smoother/include/path_smoother/common_structs.hpp 45.45% <ø> (ø)
...er/include/path_smoother/elastic_band_smoother.hpp 40.00% <ø> (ø)
...anning/path_smoother/src/elastic_band_smoother.cpp 36.71% <ø> (+0.28%) ⬆️
planning/rtc_interface/src/rtc_interface.cpp 28.24% <ø> (-0.33%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Tested it using the data from 2023-04-17-17-44-15.
Only one nit: shared_ptr -> unique_ptr as the data is not being shared

@tkimura4 tkimura4 force-pushed the fix/publish_tl_info_on_no_tl_map branch from 4b2692e to 9b69d4d Compare July 27, 2023 14:11
tkimura4 and others added 2 commits July 27, 2023 23:11
…/traffic_light_arbiter.hpp

Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkimura4
Copy link
Contributor Author

@knzo25
Thank you for your review!!!

@tkimura4 tkimura4 enabled auto-merge (squash) July 27, 2023 14:14
@tkimura4 tkimura4 merged commit 404d084 into autowarefoundation:main Jul 27, 2023
@tkimura4 tkimura4 deleted the fix/publish_tl_info_on_no_tl_map branch July 27, 2023 14:15
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jul 27, 2023
…p without traffic lights is subscribed (autowarefoundation#4428)

* fix(traffic_light_arbiter): publish traffic light info even when a map without traffic lights is subscribed

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: publish empty message if the size of elemsents_set is 0

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Update perception/traffic_light_arbiter/include/traffic_light_arbiter/traffic_light_arbiter.hpp

Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/traffic_light_arbiter/src/traffic_light_arbiter.cpp

Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kenzo Lobos Tsunekawa <kenzo.lobos@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants