Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointcloud_preprocessor): fix launch error #4431

Conversation

ismetatabay
Copy link
Member

Description

closes #4421

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jul 27, 2023
Signed-off-by: ismetatabay <ismet@leodrive.ai>
@ismetatabay ismetatabay force-pushed the fix/pointcloud_preprocessor_launch branch from 5e23365 to 5ef8a63 Compare July 27, 2023 16:15
@yukkysaito yukkysaito requested a review from YoshiRi July 28, 2023 02:32
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your job! LGTM.

@ismetatabay ismetatabay added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2f282ed) 14.89% compared to head (bf8a968) 14.89%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4431   +/-   ##
=======================================
  Coverage   14.89%   14.89%           
=======================================
  Files        1520     1520           
  Lines      104873   104873           
  Branches    31943    31943           
=======================================
  Hits        15623    15623           
  Misses      72192    72192           
  Partials    17058    17058           
Flag Coverage Δ *Carryforward flag
differential 6.78% <ø> (?)
total 14.89% <ø> (ø) Carriedforward from 2f282ed

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ismetatabay
Copy link
Member Author

@yukkysaito can you check it? @YoshiRi approved this PR 👍.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismetatabay ismetatabay merged commit ec9a392 into autowarefoundation:main Aug 1, 2023
@ismetatabay ismetatabay deleted the fix/pointcloud_preprocessor_launch branch August 1, 2023 13:37
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
* update launch file

Signed-off-by: ismetatabay <ismet@leodrive.ai>

* style(pre-commit): autofix

---------

Signed-off-by: ismetatabay <ismet@leodrive.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pointcloud_preprocessor] launchfile broken on Humble
3 participants