-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pointcloud_preprocessor): fix launch error #4431
fix(pointcloud_preprocessor): fix launch error #4431
Conversation
Signed-off-by: ismetatabay <ismet@leodrive.ai>
5e23365
to
5ef8a63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your job! LGTM.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
=======================================
Coverage 14.89% 14.89%
=======================================
Files 1520 1520
Lines 104873 104873
Branches 31943 31943
=======================================
Hits 15623 15623
Misses 72192 72192
Partials 17058 17058
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yukkysaito can you check it? @YoshiRi approved this PR 👍. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* update launch file Signed-off-by: ismetatabay <ismet@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: ismetatabay <ismet@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
Description
closes #4421
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.