Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): memorize previous object information #4433

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 27, 2023

Description

To suppress the chattering of objects appearing/disappearing, whether object's variable (e.g. velocity) is lower/higher than the threshold, the previous object information is memorized with this change.

The meaning of the counter for each object is, if the value is positive, the object appears counter times in a raw, and if negative, the object disappears counter times in a raw.

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-use-prev-info branch from 58982a3 to 64afc82 Compare August 3, 2023 02:52
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (5f15fd3) 14.86% compared to head (5086f61) 14.82%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4433      +/-   ##
==========================================
- Coverage   14.86%   14.82%   -0.04%     
==========================================
  Files        1519     1519              
  Lines      104940   105740     +800     
  Branches    31971    32522     +551     
==========================================
+ Hits        15599    15681      +82     
- Misses      72288    72924     +636     
- Partials    17053    17135      +82     
Flag Coverage Δ *Carryforward flag
differential 13.21% <0.00%> (?)
total 14.87% <ø> (+0.01%) ⬆️ Carriedforward from 5f15fd3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 changed the title Feat/dynamic avoidance use prev info feat(dynamic_avoidance): memorize previous object information Aug 3, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 3, 2023 14:22
@takayuki5168 takayuki5168 merged commit 4811435 into autowarefoundation:main Aug 5, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-use-prev-info branch August 5, 2023 01:51
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…refoundation#4433)

* feat(dynamic_avoidance): refactor previous info access

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…refoundation#4433)

* feat(dynamic_avoidance): refactor previous info access

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…refoundation#4433)

* feat(dynamic_avoidance): refactor previous info access

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…refoundation#4433)

* feat(dynamic_avoidance): refactor previous info access

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants