Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roi_cluster_fusion): fix roi_cluster_fusion died bug #4444

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jul 28, 2023

Description

This PR to fix bug of roi_cluster_fusion node died when empty pointcloud is published.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen requested a review from miursh July 28, 2023 10:15
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jul 28, 2023
@badai-nguyen badai-nguyen marked this pull request as ready for review July 28, 2023 10:18
@badai-nguyen badai-nguyen requested a review from yukkysaito as a code owner July 28, 2023 10:18
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 28, 2023
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen enabled auto-merge (squash) July 28, 2023 10:53
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (dd8e1d6) 14.91% compared to head (07fc9d2) 14.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4444      +/-   ##
==========================================
- Coverage   14.91%   14.88%   -0.04%     
==========================================
  Files        1516     1521       +5     
  Lines      104652   104887     +235     
  Branches    31853    31853              
==========================================
  Hits        15610    15610              
- Misses      72007    72242     +235     
  Partials    17035    17035              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from dd8e1d6

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ction_based_fusion/src/roi_cluster_fusion/node.cpp 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen merged commit b8aad73 into autowarefoundation:main Jul 28, 2023
badai-nguyen added a commit to badai-nguyen/autoware.universe that referenced this pull request Jul 30, 2023
…ndation#4444)

fix: fix roi_cluster_fusion died bug

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 1, 2023
…ndation#4444)

fix: fix roi_cluster_fusion died bug

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants