fix(traffic_light_arbiter): clear perception msg when the stamp is over the tolerance #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the tolerance Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
github-actions
bot
added
the
component:perception
TomohitoAndo
added
the
run:build-and-test-differential
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4464 +/- ##
=======================================
Coverage 14.91% 14.91%
=======================================
Files 1517 1517
Lines 104701 104701
Branches 31884 31884
=======================================
Hits 15619 15619
Misses 72030 72030
Partials 17052 17052
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 31, 2023
…er the tolerance (autowarefoundation#4464) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
4 tasks
TomohitoAndo
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 31, 2023
…er the tolerance (#701) fix(traffic_light_arbiter): clear perception msg when the stamp is over the tolerance (autowarefoundation#4464) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 1, 2023
…er the tolerance (autowarefoundation#4464) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
felixf4xu
pushed a commit
to felixf4xu/autoware.universe
that referenced
this pull request
Aug 2, 2023
…er the tolerance (autowarefoundation#4464) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 4, 2023
…er the tolerance (autowarefoundation#4464) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think
latest_perception_msg_should be cleared here instead oflatest_external_msg_.https://github.com/autowarefoundation/autoware.universe/pull/4464/files#diff-8488136a70c0a6c2330c7db712a8d69c5e2111f1b7f83477e67a99887933ca4dR102
Tests performed
I confirmed that this node works by following these steps.
/external/traffic_signalsEffects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.