-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avoidance): add parameter to configurate avoidance return point #4467
feat(avoidance): add parameter to configurate avoidance return point #4467
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4467 +/- ##
==========================================
- Coverage 14.91% 14.90% -0.01%
==========================================
Files 1517 1517
Lines 104701 104785 +84
Branches 31884 31938 +54
==========================================
+ Hits 15619 15622 +3
- Misses 72030 72107 +77
- Partials 17052 17056 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…utowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Felix F Xu <felixfxu@gmail.com>
…utowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…utowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…utowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…utowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
* feat(avoidance): add parameter to configurate avoidance return point (autowarefoundation#4467) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(utils): improve monotonic bound generation logic (autowarefoundation#4706) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): insert return dead line point (autowarefoundation#5029) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): exit if there is no avoidable object (autowarefoundation#5051) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Description
Add new parameter
remain_buffer_distance
in order to keep constant remaining distance between avoidance end point and path end point.Please approve ⬇️ before this PR.
autowarefoundation/autoware_launch#493
simplescreenrecorder-2023-07-31_14.54.57.mp4
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.