Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): plan path even if ego is on the original goal #4472

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 31, 2023

Description

Fix the issue that goal_planner can not generate path when the ego vehicle is on the original goal after other module(like lane change)

UC-v2-F-16-00008_001_case03_before-2023-07-31_21.09.50.mp4

tier4 internal scenario link

Related links

Tests performed

psim,
related scneario test in local

UC-v2-F-16-00008_001_case03-2023-07-31_20.36.57.mp4

tier4 internal scenario test

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2212b00) 14.91% compared to head (a47e76d) 14.91%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4472   +/-   ##
=======================================
  Coverage   14.91%   14.91%           
=======================================
  Files        1520     1520           
  Lines      104758   104758           
  Branches    31893    31893           
=======================================
  Hits        15621    15621           
  Misses      72086    72086           
  Partials    17051    17051           
Flag Coverage Δ *Carryforward flag
differential 13.28% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 2212b00

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 25.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.06% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 9a73f2c into main Aug 1, 2023
@kosuke55 kosuke55 deleted the fix/goal_planner_on_goal branch August 1, 2023 16:45
felixf4xu pushed a commit to felixf4xu/autoware.universe that referenced this pull request Aug 2, 2023
…owarefoundation#4472)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Felix F Xu <felixfxu@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants