Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): drivable area front nearest segment index #4489

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 1, 2023

Description

Without this PR, closest_idx from findNearestSegmentIndex is considered for calculating minimum index of lateral distance.
However, ideally, this closest index should be considered when minimum index of lateral distance itself is not found.
Due to the current implementation, unexpected closest index is used in some cases.

This PR calculates the minimum index of lateral distance first, and only if not found, closest index from findNearestSegmentIndex is used instead.

Tests performed

planning simulator
scenario simulator (https://evaluation.tier4.jp/evaluation/reports/e00f9794-72e8-59f4-95f8-c737db40ad67?project_id=prd_jt)

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 force-pushed the fix/drivable-area-nearest-segment-index branch from 0ed9155 to 9bdf2c7 Compare August 1, 2023 08:57
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 1, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/drivable-area-nearest-segment-index branch from 9bdf2c7 to edecb33 Compare August 3, 2023 02:40
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.04% ⚠️

Comparison is base (5f15fd3) 14.86% compared to head (edecb33) 14.83%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4489      +/-   ##
==========================================
- Coverage   14.86%   14.83%   -0.04%     
==========================================
  Files        1519     1519              
  Lines      104940   105725     +785     
  Branches    31971    32519     +548     
==========================================
+ Hits        15599    15681      +82     
- Misses      72288    72908     +620     
- Partials    17053    17136      +83     
Flag Coverage Δ *Carryforward flag
differential 13.22% <55.55%> (?)
total 14.85% <ø> (-0.01%) ⬇️ Carriedforward from 5f15fd3

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
planning/behavior_path_planner/src/utils/utils.cpp 15.66% <55.55%> (-0.04%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 marked this pull request as ready for review August 3, 2023 14:17
@takayuki5168 takayuki5168 merged commit 1e55eff into autowarefoundation:main Aug 3, 2023
@takayuki5168 takayuki5168 deleted the fix/drivable-area-nearest-segment-index branch August 3, 2023 14:17
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants