Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): change straight turn signal condition #4507

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 3, 2023

Description

Turn signal decider disable the blinker when the ego vehicle runs on a straight line at intersections. However, this causes some serious problems for the lane change and avoidance module when it tries to change lanes or avoid objects near intersections. In this PR, I change the code by disabling the blinker only when the ego vehicle stops at the intersection.

Tests performed

Scenario Test 1575/1588
TIRE IV INTERNAL LINK

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 3, 2023
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d6351fc) 14.88% compared to head (100487e) 14.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4507   +/-   ##
=======================================
  Coverage   14.88%   14.88%           
=======================================
  Files        1519     1519           
  Lines      105003   105002    -1     
  Branches    31994    31995    +1     
=======================================
  Hits        15631    15631           
+ Misses      72305    72303    -2     
- Partials    17067    17068    +1     
Flag Coverage Δ *Carryforward flag
differential 13.23% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from d6351fc

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <ø> (ø)
...er4_state_rviz_plugin/src/autoware_state_panel.hpp 0.00% <ø> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 40.72% <0.00%> (-0.30%) ⬇️
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.17% <ø> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants