Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_simulator_launch): launch camera and V2X fusion module in simple planning simulator #4522

Conversation

TomohitoAndo
Copy link
Contributor

Description

Added args to launch camera and V2X fusion modules to test this feature in scenario simulator.
modules in red rectangles in below image is fusion modules.
image

Related issue:

Tests performed

Before

Run simple planning simulator.

$ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=/tmp/sample_map vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit 2>&1 | tee autoware.log

There are no nodes related to traffic light recognition.

$ ros2 node list | grep traffic_light

After

Run simple planning simulator.

$ ros2 launch autoware_launch planning_simulator.launch.xml map_path:=/tmp/sample_map vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit 2>&1 | tee autoware.log

Modules to fusion camera and V2X are launched.

$ ros2 node list | grep traffic_light
/perception/traffic_light_recognition/camera6/classification/traffic_light_occlusion_predictor
/perception/traffic_light_recognition/camera6/classification/transform_listener_impl_564e2ac0bec8
/perception/traffic_light_recognition/traffic_light_arbiter/arbiter
/perception/traffic_light_recognition/traffic_light_arbiter/container
/perception/traffic_light_recognition/traffic_light_map_visualizer
/perception/traffic_light_recognition/traffic_light_multi_camera_fusion

Effects on system behavior

No effects because no traffic light recognition modules are launched in simple planning simulator.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… simple planning simulator

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Aug 4, 2023
@TomohitoAndo
Copy link
Contributor Author

@tkimura4
Could you check this PR? 🙏

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2023
@TomohitoAndo TomohitoAndo merged commit 0fa8b57 into autowarefoundation:main Aug 6, 2023
@TomohitoAndo TomohitoAndo deleted the chore/enable-traffic-light-fusion-in-psim branch August 6, 2023 06:50
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 7, 2023
… simple planning simulator (autowarefoundation#4522)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
… simple planning simulator (autowarefoundation#4522)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Aug 17, 2023
… simple planning simulator (autowarefoundation#4522)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Aug 17, 2023
… simple planning simulator (#737)

chore(tier4_simulator_launch): launch camera and V2X fusion module in simple planning simulator (autowarefoundation#4522)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants