Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): goal planner sudden decel #4529

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 5, 2023

Description

Fixed a sudden slowdown in the goal planner due to loose criteria with stop_distance_buffer for hasEnoghDistance
In this PR use the buffer only when the ego is stopped.

e.g. lane change -> goal planner

goal_planner_stop-2023-08-04_21.14.00.mp4

Related links

Tests performed

psim

tier4 internal sceanrio simulator

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 5, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (e39c928) 14.85% compared to head (ecbb2db) 14.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4529      +/-   ##
==========================================
- Coverage   14.85%   14.85%   -0.01%     
==========================================
  Files        1521     1521              
  Lines      105206   105229      +23     
  Branches    32013    32023      +10     
==========================================
  Hits        15627    15627              
- Misses      72507    72529      +22     
- Partials    17072    17073       +1     
Flag Coverage Δ *Carryforward flag
differential 13.19% <0.00%> (?)
total 14.86% <ø> (+0.01%) ⬆️ Carriedforward from e39c928

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.01% <0.00%> (-0.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 1e700ed into main Aug 5, 2023
@kosuke55 kosuke55 deleted the fix/goal_planner_sudden_decel branch August 5, 2023 15:07
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 13, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants