Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): consider shifting objects #4545

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 7, 2023

Description

The current dynamic avoidance cannot deal with early avoidance against the object laterally coming close to the ego for avoiding parked vehicles since the predicted path is not used due to its instability.

This PR will fix the issue by extracting the objects from the drivable area with "the lateral offset to shift in X [seconds]" by the object's lateral velocity.

simplescreenrecorder-2023-08-07_21.57.30.mp4

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 7, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-consider-shift-objects branch from 0affc51 to 535e4a1 Compare August 7, 2023 12:47
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 7, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review August 7, 2023 13:00
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (48129f1) 14.81% compared to head (535e4a1) 14.81%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4545   +/-   ##
=======================================
  Coverage   14.81%   14.81%           
=======================================
  Files        1526     1526           
  Lines      105559   105556    -3     
  Branches    32063    32059    -4     
=======================================
  Hits        15638    15638           
  Misses      72846    72846           
+ Partials    17075    17072    -3     
Flag Coverage Δ *Carryforward flag
differential 13.11% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 48129f1

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 22.00% <ø> (ø)
planning/route_handler/src/route_handler.cpp 25.05% <ø> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 merged commit 0dae23f into autowarefoundation:main Aug 7, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-consider-shift-objects branch August 7, 2023 17:33
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…n#4545)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…n#4545)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Nov 26, 2023
…n#4545)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Dec 25, 2023
…n#4545)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants