Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): add a guard for rerouting while not following lane #4564

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 8, 2023

Description

Add a guard for the mission planner to prevent it from rerouting while the behavior path planner is in lane change, avoidance, and other modules(start planner, goal planner and etc). This can also prevent the entire planner from generating an unsafe path.

Screencast.from.2023.08.09.00.25.00.webm

Tests performed

PSim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…lane

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
@purewater0901 purewater0901 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 8, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 8, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2e5752f) 14.80% compared to head (942c786) 14.80%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4564   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1527     1527           
  Lines      105643   105632   -11     
  Branches    32096    32084   -12     
=======================================
  Hits        15642    15642           
+ Misses      72925    72916    -9     
+ Partials    17076    17074    -2     
Flag Coverage Δ *Carryforward flag
differential 12.52% <0.00%> (?)
total 14.81% <ø> (+<0.01%) ⬆️ Carriedforward from 2e5752f

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 8.33% <ø> (ø)
..._planner/utils/avoidance/avoidance_module_data.hpp 0.00% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 12.24% <ø> (+0.21%) ⬆️
...ath_planner/src/scene_module/avoidance/manager.cpp 7.11% <ø> (+0.06%) ⬆️
...h_planner/src/scene_module/lane_change/manager.cpp 7.64% <ø> (+0.09%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.36% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purewater0901 purewater0901 merged commit 81d2c0c into main Aug 8, 2023
@purewater0901 purewater0901 deleted the feat/add-reroute-guard branch August 8, 2023 15:59
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…lane (autowarefoundation#4564)

feat(mission_planner): add a guard for rerouting while not follwoing lane

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants