-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): fix simultaneous execution #4622
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4622 +/- ##
==========================================
+ Coverage 14.82% 14.84% +0.02%
==========================================
Files 1529 1529
Lines 105813 105832 +19
Branches 32244 32249 +5
==========================================
+ Hits 15690 15716 +26
+ Misses 72966 72929 -37
- Partials 17157 17187 +30
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b7563f7
to
6aba0d7
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
6aba0d7
to
9dc0f33
Compare
@satoshi-ota tier4 scenario simulator 1584/1584 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks.
…ation#4622) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4622) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4622) (#740) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…ation#4622) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
The value of
isSimultaneousExecutable*
cannot be changed dynamically when the module is not requested.For example, we want the value of fixed_goal_planner to always be true, but if there is another module ahead of it in the first place, the module will not be requeted and the value cannot be changed.
In this PR, the value is changed to be changed on the manager side.
Also, complex functions were removed.
Related links
Tests performed
psim
LC -> fixed_goal_planner
fixed_goal_planner-2023-08-14_16.34.26.mp4
back pull out -> avoidance
back_pull_out_to_avoidance-2023-08-14_18.08.42.mp4
tier4 scenario simulator 1584/1584
https://github.com/tier4/sim_evaluation_tools_test/issues/109
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.