Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix simultaneous execution #4622

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 14, 2023

Description

The value of isSimultaneousExecutable* cannot be changed dynamically when the module is not requested.
For example, we want the value of fixed_goal_planner to always be true, but if there is another module ahead of it in the first place, the module will not be requeted and the value cannot be changed.
In this PR, the value is changed to be changed on the manager side.
Also, complex functions were removed.

Related links

Tests performed

psim

LC -> fixed_goal_planner

fixed_goal_planner-2023-08-14_16.34.26.mp4

back pull out -> avoidance

back_pull_out_to_avoidance-2023-08-14_18.08.42.mp4

tier4 scenario simulator 1584/1584

https://github.com/tier4/sim_evaluation_tools_test/issues/109

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 14, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 1.72% and project coverage change: +0.02% 🎉

Comparison is base (e0e9fcf) 14.82% compared to head (9dc0f33) 14.84%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4622      +/-   ##
==========================================
+ Coverage   14.82%   14.84%   +0.02%     
==========================================
  Files        1529     1529              
  Lines      105813   105832      +19     
  Branches    32244    32249       +5     
==========================================
+ Hits        15690    15716      +26     
+ Misses      72966    72929      -37     
- Partials    17157    17187      +30     
Flag Coverage Δ *Carryforward flag
differential 13.23% <1.72%> (?)
total 14.83% <ø> (+<0.01%) ⬆️ Carriedforward from e0e9fcf

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...path_planner/scene_module/goal_planner/manager.hpp 100.00% <ø> (ø)
...th_planner/scene_module/scene_module_interface.hpp 12.23% <ø> (+0.34%) ⬆️
...er/scene_module/scene_module_manager_interface.hpp 28.70% <0.00%> (+3.70%) ⬆️
...ath_planner/scene_module/start_planner/manager.hpp 100.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 0.00% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 6.54% <0.00%> (-0.07%) ⬇️
...planner/src/scene_module/start_planner/manager.cpp 9.63% <0.00%> (-2.67%) ⬇️
...cene_module/start_planner/start_planner_module.cpp 4.03% <ø> (+0.03%) ⬆️
...avior_path_planner/src/utils/goal_planner/util.cpp 3.84% <0.00%> (-0.64%) ⬇️
..._planner/src/scene_module/goal_planner/manager.cpp 8.55% <11.11%> (+0.16%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/fixed_goal_planner_execution branch from 6aba0d7 to 9dc0f33 Compare August 14, 2023 10:40
@kosuke55
Copy link
Contributor Author

@satoshi-ota
evaluator result looks good

tier4 scenario simulator 1584/1584
https://github.com/tier4/sim_evaluation_tools_test/issues/109

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks.

@kosuke55 kosuke55 merged commit e1472ea into main Aug 15, 2023
@kosuke55 kosuke55 deleted the fix/fixed_goal_planner_execution branch August 15, 2023 01:51
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 17, 2023
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Aug 17, 2023
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants