-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rename map_projector_type to map_projector_info #4664
feat!: rename map_projector_type to map_projector_info #4664
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4664 +/- ##
========================================
Coverage 14.89% 14.89%
========================================
Files 1549 1548 -1
Lines 106946 106770 -176
Branches 32784 32682 -102
========================================
- Hits 15926 15900 -26
+ Misses 73627 73555 -72
+ Partials 17393 17315 -78
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that the topic was output properly.
LGTM
Description
I'd like to rename
/map/map_projector_type
to/map/map_projector_info
.Reasons:
tier4_map_msgs/msg/MapProjectorInfo
which is a little bit different from the topic name. This inconsistency may confuse developers in the near future that may lead to a potential bugs.Related links
TIER IV INTERNAL LINK
Tests performed
ros2 topic info -v /map/map_projector_type
before this PR andros2 topic info -v /map/map_projector_info
after this PR, and confirmed that both matches the same.ros2 topic info -v /map/map_projector_type
before this PR andros2 topic info -v /map/map_projector_info
after this PR, and confirmed that both matches the same.Notes for reviewers
N/A
Interface changes
Yes. The topic name has been changed.
Effects on system behavior
No effect expected
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.