-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(lane_change): add missing explanation for lane change parameters #4703
docs(lane_change): add missing explanation for lane change parameters #4703
Conversation
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4703 +/- ##
==========================================
- Coverage 14.89% 14.78% -0.11%
==========================================
Files 1549 1549
Lines 106955 107848 +893
Branches 32790 33419 +629
==========================================
+ Hits 15927 15950 +23
- Misses 73635 74421 +786
- Partials 17393 17477 +84
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…autowarefoundation#4703) * docs(lane_change): add missing explanation for lane change parameters Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * docs(lane_change): fix spell Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * docs(lane_change): add turn signal parameters Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Description
Add missing explanation for lane change parameters.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.