Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lane_change): add missing explanation for lane change parameters #4703

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Aug 22, 2023

Description

Add missing explanation for lane change parameters.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 22, 2023
rej55 added 2 commits August 22, 2023 16:18
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (b048ff4) 14.89% compared to head (aee0abe) 14.78%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4703      +/-   ##
==========================================
- Coverage   14.89%   14.78%   -0.11%     
==========================================
  Files        1549     1549              
  Lines      106955   107848     +893     
  Branches    32790    33419     +629     
==========================================
+ Hits        15927    15950      +23     
- Misses      73635    74421     +786     
- Partials    17393    17477      +84     
Flag Coverage Δ *Carryforward flag
differential 13.21% <ø> (?)
total 14.89% <ø> (+<0.01%) ⬆️ Carriedforward from b048ff4

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit c8ee0d4 into autowarefoundation:main Aug 24, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 24, 2023
…autowarefoundation#4703)

* docs(lane_change): add missing explanation for lane change parameters

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* docs(lane_change): fix spell

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* docs(lane_change): add turn signal parameters

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants