Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cspell errors and enable spell-check in planning directories #4716

Merged
merged 13 commits into from
Aug 24, 2023

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Aug 23, 2023

Description

  • fix all cspell errors in planning directories
  • enable spell-check-partial for planning directories

Tests performed

  • build test by GithHub Actions
  • spell-check-partial by GitHub Actions

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…previous_lanelets

Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 23, 2023
@HansRobo HansRobo changed the title chore: fix cspell erros and enable spell-check in planning directories chore: fix cspell errors and enable spell-check in planning directories Aug 23, 2023
@HansRobo HansRobo marked this pull request as ready for review August 23, 2023 01:55
@HansRobo HansRobo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 23, 2023
@HansRobo HansRobo enabled auto-merge (squash) August 23, 2023 02:13
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22% ⚠️

Comparison is base (cf42588) 15.10% compared to head (92df8db) 14.88%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4716      +/-   ##
==========================================
- Coverage   15.10%   14.88%   -0.22%     
==========================================
  Files        1563     1548      -15     
  Lines      107888   106848    -1040     
  Branches    33101    32762     -339     
==========================================
- Hits        16300    15908     -392     
+ Misses      73819    73555     -264     
+ Partials    17769    17385     -384     
Flag Coverage Δ *Carryforward flag
differential 10.73% <0.00%> (?)
total 14.90% <ø> (-0.21%) ⬇️ Carriedforward from 5688b61

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ity_intersection_module/src/scene_intersection.cpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <0.00%> (ø)
...k_constrained_smoother/velocity_planning_utils.cpp 0.00% <0.00%> (ø)
...e_planner/include/obstacle_cruise_planner/node.hpp 11.11% <ø> (ø)

... and 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HansRobo
Copy link
Member Author

@TakaHoribe @rej55 @mkuri
Could you review as code owners of motion_velocity_smoother?

@rej55
Copy link
Contributor

rej55 commented Aug 24, 2023

@HansRobo Sorry for late review. Thank you for fix!

@HansRobo HansRobo merged commit febb989 into main Aug 24, 2023
@HansRobo HansRobo deleted the fix/cspell-errors/util-cpp branch August 24, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants