-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id for one traffic light #4727
fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id for one traffic light #4727
Conversation
…ement id for one traffic light Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4727 +/- ##
=======================================
Coverage 15.07% 15.07%
=======================================
Files 1560 1560
Lines 107737 107729 -8
Branches 33022 33021 -1
=======================================
Hits 16244 16244
+ Misses 73785 73777 -8
Partials 17708 17708
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@miursh |
@TomohitoAndo Than you!! I will check this by tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ement id for one traffic light (autowarefoundation#4727) Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Description
In the current implementation, if a traffic light is linked to multiple regulatory elements, the multi-camera fusion only publishes one signal with a regulatory element. I've updated it to publish all associated regulatory elements with the traffic light perception results.
Tests performed
Tested in simple planning simulator.
This was tested in a basic planning simulator. Below is the output when traffic light 2400 is associated with regulatory elements 1489 and 1493.
Before
After
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.