Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id for one traffic light #4727

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Aug 23, 2023

Description

In the current implementation, if a traffic light is linked to multiple regulatory elements, the multi-camera fusion only publishes one signal with a regulatory element. I've updated it to publish all associated regulatory elements with the traffic light perception results.

image

Tests performed

Tested in simple planning simulator.
This was tested in a basic planning simulator. Below is the output when traffic light 2400 is associated with regulatory elements 1489 and 1493.

Before

$ ros2 topic echo /perception/traffic_light_recognition/internal/traffic_signals
stamp:
  sec: 1692786155
  nanosec: 696961024
signals:
- traffic_signal_id: 1489
  elements:
  - color: 1
    shape: 1
    status: 0
    confidence: 0.9967631101608276

After

stamp:
  sec: 1692786410
  nanosec: 596963840
signals:
- traffic_signal_id: 1489
  elements:
  - color: 1
    shape: 1
    status: 0
    confidence: 0.6648706793785095
- traffic_signal_id: 1493
  elements:
  - color: 1
    shape: 1
    status: 0
    confidence: 0.6648706793785095

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ement id for one traffic light

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 23, 2023
@TomohitoAndo TomohitoAndo added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Aug 23, 2023
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 23, 2023
@TomohitoAndo TomohitoAndo changed the title fix(traffic_light_multi_camera_fusion): assign multiple regulatory el… fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id Aug 23, 2023
@TomohitoAndo TomohitoAndo changed the title fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id fix(traffic_light_multi_camera_fusion): assign multiple regulatory element id for one traffic light Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a69ee45) 15.07% compared to head (35a7d38) 15.07%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4727   +/-   ##
=======================================
  Coverage   15.07%   15.07%           
=======================================
  Files        1560     1560           
  Lines      107737   107729    -8     
  Branches    33022    33021    -1     
=======================================
  Hits        16244    16244           
+ Misses      73785    73777    -8     
  Partials    17708    17708           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.07% <ø> (+<0.01%) ⬆️ Carriedforward from a69ee45

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...include/traffic_light_multi_camera_fusion/node.hpp 0.00% <ø> (ø)
...ion/traffic_light_multi_camera_fusion/src/node.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 15.37% <ø> (+0.01%) ⬆️
sensing/gnss_poser/include/gnss_poser/convert.hpp 0.00% <ø> (ø)
...ensing/gnss_poser/include/gnss_poser/gnss_stat.hpp 0.00% <ø> (ø)
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TomohitoAndo TomohitoAndo marked this pull request as ready for review August 24, 2023 01:53
@TomohitoAndo
Copy link
Contributor Author

@miursh
Could you review? 🙏

@miursh
Copy link
Contributor

miursh commented Aug 24, 2023

@TomohitoAndo Than you!! I will check this by tonight.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 4cf251e into autowarefoundation:main Aug 25, 2023
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 25, 2023
…ement id for one traffic light (autowarefoundation#4727)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo deleted the fix/multi-camera-fusion-reg-id branch August 28, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants