Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(intersection): use getOrDeclareParameter #4767

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 28, 2023

Description

use tier4_autoware_utils::getOrDeclareParameter for the ros parameter to prevent duplicate parameter declaration.

Tests performed

Run psim

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 28, 2023
@TakaHoribe TakaHoribe marked this pull request as ready for review August 28, 2023 04:57
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@TakaHoribe TakaHoribe enabled auto-merge (squash) August 28, 2023 05:02
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (e897b19) 15.11% compared to head (de16124) 15.11%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4767      +/-   ##
==========================================
- Coverage   15.11%   15.11%   -0.01%     
==========================================
  Files        1568     1568              
  Lines      108122   108104      -18     
  Branches    33164    33158       -6     
==========================================
- Hits        16346    16342       -4     
+ Misses      73995    73978      -17     
- Partials    17781    17784       +3     
Flag Coverage Δ *Carryforward flag
differential 7.06% <0.00%> (?)
total 15.12% <ø> (+<0.01%) ⬆️ Carriedforward from e897b19

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...clude/behavior_path_planner/marker_utils/utils.hpp 0.00% <ø> (ø)
...ath_planner/src/marker_utils/lane_change/debug.cpp 0.00% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 6.41% <ø> (+0.08%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 4.04% <ø> (+0.04%) ⬆️
...ner/src/utils/path_safety_checker/safety_check.cpp 29.13% <ø> (-1.47%) ⬇️
...avior_velocity_intersection_module/src/manager.cpp 18.86% <0.00%> (-0.28%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe merged commit 61630e6 into autowarefoundation:main Aug 28, 2023
@TakaHoribe TakaHoribe deleted the intersection-get-param branch August 28, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants