-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): consider amber traffic signal for collision detection level #5096
feat(intersection): consider amber traffic signal for collision detection level #5096
Conversation
…tion level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
cc2f4f8
to
2898ca5
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
eee92c0
to
b81bd1a
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5096 +/- ##
==========================================
- Coverage 15.77% 15.70% -0.08%
==========================================
Files 1584 1584
Lines 109568 110415 +847
Branches 33728 34337 +609
==========================================
+ Hits 17286 17336 +50
- Misses 73656 74330 +674
- Partials 18626 18749 +123
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
14e2f2e
to
f031eff
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
f031eff
to
fc3d783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion level (autowarefoundation#5096) * feat(intersection): consider amber traffic signal for collision detection level Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * protected -> prioritized Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
Currently, the collision detection margin is prepared for the case where the traffic signal is green and red.
For more efficient intersection behavior, this PR added a collision detection margin for amber color.
Three traffic protected levels are defined.
https://star4.slack.com/archives/C03QW0GU6P7/p1695379403867969?thread_ts=1695378610.532759&cid=C03QW0GU6P7
Tests performed
psim
Effects on system behavior
More efficient intersection behavior considering amber traffic signal.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.