Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): consider amber traffic signal for collision detection level #5096

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 24, 2023

Description

Currently, the collision detection margin is prepared for the case where the traffic signal is green and red.
For more efficient intersection behavior, this PR added a collision detection margin for amber color.

Three traffic protected levels are defined.

  • fully protected
    • The target lane's traffic signal is red or the ego's traffic signal has an arrow.
  • partially protected
    • The target lane's traffic signal is amber
  • unprotected
    • The target lane's traffic signal is green

https://star4.slack.com/archives/C03QW0GU6P7/p1695379403867969?thread_ts=1695378610.532759&cid=C03QW0GU6P7

Tests performed

psim

Effects on system behavior

More efficient intersection behavior considering amber traffic signal.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 24, 2023
…tion level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/intersection-traffic-protected-level-for-yellow-signal branch from cc2f4f8 to 2898ca5 Compare September 24, 2023 02:10
@github-actions github-actions bot removed the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 24, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review September 24, 2023 02:16
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 24, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (9402bb5) 15.77% compared to head (fc3d783) 15.70%.
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5096      +/-   ##
==========================================
- Coverage   15.77%   15.70%   -0.08%     
==========================================
  Files        1584     1584              
  Lines      109568   110415     +847     
  Branches    33728    34337     +609     
==========================================
+ Hits        17286    17336      +50     
- Misses      73656    74330     +674     
- Partials    18626    18749     +123     
Flag Coverage Δ *Carryforward flag
differential 6.73% <0.00%> (?)
total 15.78% <ø> (+<0.01%) ⬆️ Carriedforward from b81bd1a

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 17.80% <0.00%> (-0.77%) ⬇️
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@takayuki5168 takayuki5168 force-pushed the feat/intersection-traffic-protected-level-for-yellow-signal branch from 14e2f2e to f031eff Compare September 24, 2023 13:17
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/intersection-traffic-protected-level-for-yellow-signal branch from f031eff to fc3d783 Compare September 24, 2023 13:18
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 5b92c71 into autowarefoundation:main Sep 25, 2023
@takayuki5168 takayuki5168 deleted the feat/intersection-traffic-protected-level-for-yellow-signal branch September 25, 2023 05:04
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Oct 31, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
soblin pushed a commit to tier4/autoware.universe that referenced this pull request Nov 2, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
soblin pushed a commit to soblin/autoware.universe that referenced this pull request Nov 18, 2023
…tion level (autowarefoundation#5096)

* feat(intersection): consider amber traffic signal for collision detection level

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* protected -> prioritized

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants