-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): ignore high curvature lane occlusion #5223
Merged
soblin
merged 3 commits into
autowarefoundation:main
from
soblin:feat/intersection/ignore-high-curvature-lane-occlusion
Oct 4, 2023
Merged
feat(intersection): ignore high curvature lane occlusion #5223
soblin
merged 3 commits into
autowarefoundation:main
from
soblin:feat/intersection/ignore-high-curvature-lane-occlusion
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
464f1f9
to
b03c76b
Compare
7 tasks
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara
approved these changes
Oct 4, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5223 +/- ##
==========================================
- Coverage 14.79% 14.79% -0.01%
==========================================
Files 1648 1648
Lines 113928 113954 +26
Branches 35072 35094 +22
==========================================
Hits 16860 16860
- Misses 78145 78166 +21
- Partials 18923 18928 +5
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 4, 2023
…ndation#5223) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This was referenced Oct 4, 2023
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 8, 2023
…ndation#5223) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This was referenced Oct 11, 2023
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 11, 2023
…ndation#5223) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For occlusion detection, the lanelets whose maximum curvature is higher than the threshold are not used.
TODO: trim part of lanelet with low curvature
Related links
https://tier4.atlassian.net/browse/RT1-3949
launcher PR: autowarefoundation/autoware_launch#619
Tests performed
Psim
left turn with straghit attention lanes
right turn with curved attention lanes
curved lanelet is not used as the occlusion detection area (pink)

Notes for reviewers
Interface changes
none.
Effects on system behavior
none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.