Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): ignore high curvature lane occlusion #5223

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Oct 4, 2023

Description

For occlusion detection, the lanelets whose maximum curvature is higher than the threshold are not used.

TODO: trim part of lanelet with low curvature

Related links

https://tier4.atlassian.net/browse/RT1-3949
launcher PR: autowarefoundation/autoware_launch#619

Tests performed

Psim

left turn with straghit attention lanes

image

right turn with curved attention lanes

curved lanelet is not used as the occlusion detection area (pink)
image

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 4, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin marked this pull request as ready for review October 4, 2023 11:35
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 4, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (5fed746) 14.79% compared to head (fe13810) 14.79%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5223      +/-   ##
==========================================
- Coverage   14.79%   14.79%   -0.01%     
==========================================
  Files        1648     1648              
  Lines      113928   113954      +26     
  Branches    35072    35094      +22     
==========================================
  Hits        16860    16860              
- Misses      78145    78166      +21     
- Partials    18923    18928       +5     
Flag Coverage Δ *Carryforward flag
differential 6.39% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 5fed746

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)
...ior_velocity_intersection_module/src/util_type.hpp 0.00% <ø> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% <0.00%> (ø)
...avior_velocity_intersection_module/src/manager.cpp 16.31% <0.00%> (-0.28%) ⬇️
...behavior_velocity_intersection_module/src/util.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 8770e1e into autowarefoundation:main Oct 4, 2023
@soblin soblin deleted the feat/intersection/ignore-high-curvature-lane-occlusion branch October 4, 2023 12:17
soblin added a commit to tier4/autoware.universe that referenced this pull request Oct 4, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 8, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants