Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): prevent node from dying for trimmed shifted path #5271

Merged

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Description

getPathTurnSignal function uses shifted_path and shift_line``'s start_idxandend_idx information to generate turn signal information. However, there are possibility that the path points is deleted byPathShifter, which will result in the number of points in shifted_pathis less thanend_idx`.
To avoid behavior path planner node dead, I have added a guard.
As this is mostly happens for lane change module, we also add the guard to remove lane change candidate path when this happens.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 11, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2aa9d1c) 14.79% compared to head (f3a22d6) 14.81%.
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5271      +/-   ##
==========================================
+ Coverage   14.79%   14.81%   +0.01%     
==========================================
  Files        1646     1646              
  Lines      114015   116195    +2180     
  Branches    35203    36818    +1615     
==========================================
+ Hits        16871    17209     +338     
- Misses      78146    79676    +1530     
- Partials    18998    19310     +312     
Flag Coverage Δ *Carryforward flag
differential 12.56% <0.00%> (?)
total 14.79% <ø> (+<0.01%) ⬆️ Carriedforward from 2aa9d1c

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ing/behavior_path_planner/src/utils/path_utils.cpp 13.99% <0.00%> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.43% <0.00%> (-0.01%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit df83621 into autowarefoundation:main Oct 13, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the fix-lc-turn-signal-dead-node branch October 13, 2023 04:47
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 13, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Oct 14, 2023
…utowarefoundation#5271) (#938)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants