Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(obstacle_cruise)!: remove unused params #5738

Conversation

yuki-takagi-66
Copy link
Contributor

Description

remove unused params corresponds to #5619

launch PR: autowarefoundation/autoware_launch#716

Tests performed

psim tests was perfomed.
Screenshot from 2023-12-01 14-02-27

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 1, 2023
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review December 1, 2023 05:32
@yuki-takagi-66 yuki-takagi-66 changed the title chore!: remove unused params chore(obstacle_cruise)!: remove unused params Dec 1, 2023
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (765a596) 15.32% compared to head (c69cd1e) 8.41%.
Report is 125 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5738       +/-   ##
==========================================
- Coverage   15.32%   8.41%    -6.91%     
==========================================
  Files        1721      18     -1703     
  Lines      118559    2281   -116278     
  Branches    37995    1231    -36764     
==========================================
- Hits        18169     192    -17977     
+ Misses      79657    1756    -77901     
+ Partials    20733     333    -20400     
Flag Coverage Δ
differential 8.41% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 917bcae into autowarefoundation:main Dec 4, 2023
@yuki-takagi-66 yuki-takagi-66 deleted the chore/obstacle_cruise-remove-unused-params branch December 4, 2023 02:48
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 5, 2023
chore!: remove unused params

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
chore!: remove unused params

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
chore!: remove unused params

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants