Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radar_threshold_filter): add unit test #5817

Merged
merged 6 commits into from
Dec 11, 2023
Merged

feat(radar_threshold_filter): add unit test #5817

merged 6 commits into from
Dec 11, 2023

Conversation

N-Eiki
Copy link
Contributor

@N-Eiki N-Eiki commented Dec 8, 2023 •
edited
Loading

Description

add z filter params to radar_threshold_filter_node.cpp
add isWithin filter unit test

Related links

Tests performed

test by colcon test

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

N-Eiki added 4 commits December 8, 2023 15:18
@N-Eiki
update cmakelists
336fd6c 
Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
@N-Eiki
add z filter param
7982b50 
Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
@N-Eiki
isWithin func private -> public
36e2618 
Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
@N-Eiki
add test code
40ae39a 
Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Dec 8, 2023
@miursh miursh added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
scepter914
scepter914 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Dec 11, 2023 •
edited
Loading

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (5af6f44) 15.27% compared to head (e8c589b) 15.30%.
Report is 2 commits behind head on main.

Files Patch % Lines
...r_threshold_filter/test_radar_threshold_filter.cpp 51.16% 0 Missing and 21 partials ⚠️
...eshold_filter_node/radar_threshold_filter_node.cpp 0.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5817      +/-   ##
==========================================
+ Coverage   15.27%   15.30%   +0.03%     
==========================================
  Files        1739     1740       +1     
  Lines      119819   119854      +35     
  Branches    36378    36441      +63     
==========================================
+ Hits        18302    18347      +45     
+ Misses      81037    80974      -63     
- Partials    20480    20533      +53
Flag Coverage Δ *Carryforward flag
differential 41.28% <44.89%> (?)
total 15.27% <ø> (+<0.01%) ⬆️ Carriedforward from 5af6f44

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scepter914 scepter914 merged commit 84b658b into autowarefoundation:main Dec 11, 2023
22 of 23 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@N-Eiki @pre-commit-ci
@scepter914 @danielsanchezaran
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
c97e8d7 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@N-Eiki @pre-commit-ci
@scepter914 @karishma1911
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
eb71fec 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@N-Eiki @pre-commit-ci
@scepter914 @karishma1911
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
007f2cd 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@N-Eiki @pre-commit-ci
@scepter914 @karishma1911
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
0626740 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@N-Eiki @pre-commit-ci
@scepter914 @karishma1911
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
1a6f183 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@N-Eiki @pre-commit-ci
@scepter914 @karishma1911
feat(radar_threshold_filter): add unit test (autowarefoundation#5817)
74bf5ab 
* update cmakelists

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add z filter param

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* isWithin func private -> public

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* add test code

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: N-Eiki <naganagaeichan@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Satoshi Tanaka <16330533+scepter914@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scepter914 scepter914 scepter914 approved these changes

@miursh miursh Awaiting requested review from miursh

Assignees
No one assigned
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N-Eiki @scepter914 @miursh