-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(localization_util): fixed rejection criteria of SmartPoseBuffer::interpolate #5818
Merged
SakodaShintaro
merged 1 commit into
autowarefoundation:main
from
SakodaShintaro:fix/smart_pose_buffer_rejection_criteria
Dec 11, 2023
Merged
fix(localization_util): fixed rejection criteria of SmartPoseBuffer::interpolate #5818
SakodaShintaro
merged 1 commit into
autowarefoundation:main
from
SakodaShintaro:fix/smart_pose_buffer_rejection_criteria
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
github-actions
bot
added
the
component:localization
Vehicle's position determination in its environment. (auto-assigned)
label
Dec 8, 2023
SakodaShintaro
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 8, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5818 +/- ##
===========================================
- Coverage 15.32% 12.88% -2.45%
===========================================
Files 1721 14 -1707
Lines 118559 1172 -117387
Branches 37995 663 -37332
===========================================
- Hits 18169 151 -18018
+ Misses 79657 799 -78858
+ Partials 20733 222 -20511
☔ View full report in Codecov by Sentry. |
SakodaShintaro
requested review from
KYabuuchi,
Motsu-san and
YamatoAndo
as code owners
December 11, 2023 00:14
KYabuuchi
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SakodaShintaro
merged commit Dec 11, 2023
89d4462
into
autowarefoundation:main
32 of 34 checks passed
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed rejection criteria of
SmartPoseBuffer::interpolate
.See comments in changed code.
Tests performed
It has been confirmed that the
logging_simulator
runs with the same accuracy as before on AWSIM data with GT.Effects on system behavior
There are no effects on system behavior for basic vehicles.
In environments where LiDAR is lightweight, such as AWSIM, SmartPoseBuffer::interpolate are less likely to fail.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.