-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(side_shift): separate side shift module #5820
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:refactor/separate-side-shift
Dec 9, 2023
Merged
refactor(side_shift): separate side shift module #5820
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
satoshi-ota:refactor/separate-side-shift
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
soblin,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4 and
zulfaqar-azmi-t4
as code owners
December 8, 2023 08:13
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Dec 8, 2023
satoshi-ota
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Dec 8, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
force-pushed
the
refactor/separate-side-shift
branch
from
December 8, 2023 08:30
a5a5df2
to
cd10b8b
Compare
kyoichi-sugahara
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you sooooo much!
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Dec 15, 2023
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Dec 19, 2023
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖[deprecated] Generated by Copilot at a5a5df2
Refactored the side shift scene module from the
behavior_path_planner
package to a separate packagebehavior_path_side_shift_module
. This improves the modularity, reusability, and configurability of the scene modules for planning. Renamed and moved the source files, header files, parameter files, and plugin descriptions accordingly. Added unit tests for the side shift module using theplanning_interface_test_manager
package.Tests performed
Psim
simplescreenrecorder-2023-12-08_17.11.48.mp4
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.