Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(side_shift): separate side shift module #5820

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 8, 2023

Description

🤖[deprecated] Generated by Copilot at a5a5df2

Refactored the side shift scene module from the behavior_path_planner package to a separate package behavior_path_side_shift_module. This improves the modularity, reusability, and configurability of the scene modules for planning. Renamed and moved the source files, header files, parameter files, and plugin descriptions accordingly. Added unit tests for the side shift module using the planning_interface_test_manager package.

Tests performed

Psim

simplescreenrecorder-2023-12-08_17.11.48.mp4

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 8, 2023
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
@kyoichi-sugahara kyoichi-sugahara self-assigned this Dec 8, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the refactor/separate-side-shift branch from a5a5df2 to cd10b8b Compare December 8, 2023 08:30
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1933 lines in your changes are missing coverage. Please review.

Comparison is base (765a596) 15.32% compared to head (cd10b8b) 8.93%.
Report is 181 commits behind head on main.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/scene.cpp 13.04% 561 Missing and 92 partials ⚠️
...path_avoidance_module/src/shift_line_generator.cpp 12.99% 443 Missing and 66 partials ⚠️
...nning/behavior_path_avoidance_module/src/utils.cpp 3.75% 195 Missing and 10 partials ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 188 Missing ⚠️
...th_avoidance_by_lane_change_module/src/manager.cpp 17.70% 0 Missing and 79 partials ⚠️
...nning/behavior_path_avoidance_module/src/debug.cpp 0.00% 61 Missing ⚠️
...ing/behavior_path_avoidance_module/src/manager.cpp 18.86% 0 Missing and 43 partials ⚠️
...test/test_behavior_path_planner_node_interface.cpp 25.53% 0 Missing and 35 partials ⚠️
..._planner_module/src/default_fixed_goal_planner.cpp 0.00% 34 Missing ⚠️
...test/test_behavior_path_planner_node_interface.cpp 26.66% 0 Missing and 33 partials ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #5820       +/-   ##
==========================================
- Coverage   15.32%   8.93%    -6.39%     
==========================================
  Files        1721      84     -1637     
  Lines      118559   10975   -107584     
  Branches    37995    4458    -33537     
==========================================
- Hits        18169     981    -17188     
+ Misses      79657    8257    -71400     
+ Partials    20733    1737    -18996     
Flag Coverage Δ
differential 8.93% <12.53%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you sooooo much!

@satoshi-ota satoshi-ota merged commit 41e5903 into autowarefoundation:main Dec 9, 2023
23 of 26 checks passed
@satoshi-ota satoshi-ota deleted the refactor/separate-side-shift branch December 9, 2023 08:55
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…5820)

* refactor(side_shift): separate side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove side shift module

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants