Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_utils): apply clang-tidy result #5829

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Dec 11, 2023

Description

🤖[deprecated] Generated by Copilot at 29e9f44

This pull request improves the code quality, readability, and consistency of the motion_utils package, by refactoring, simplifying, and fixing some parts of the header and source files. It also updates the header include conventions to follow the ROS 2 style and the detail subdirectory for message struct headers.

Additional note

What are the things that is not fixed

  1. Function case: not going to fix camelCase to snake_case
  2. Narrowing conversion
  3. Unincluded header due to extern template being used.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 11, 2023
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 enabled auto-merge (squash) December 11, 2023 06:57
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (f41d3fa) 15.28% compared to head (29e9f44) 15.26%.
Report is 5 commits behind head on main.

Files Patch % Lines
...ils/include/motion_utils/trajectory/trajectory.hpp 21.42% 6 Missing and 5 partials ⚠️
common/motion_utils/src/distance/distance.cpp 0.00% 0 Missing and 1 partial ⚠️
...n_utils/src/marker/virtual_wall_marker_creator.cpp 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
- Coverage   15.28%   15.26%   -0.03%     
==========================================
  Files        1739     1739              
  Lines      119756   120012     +256     
  Branches    36369    36446      +77     
==========================================
+ Hits        18301    18314      +13     
- Misses      80976    81214     +238     
- Partials    20479    20484       +5     
Flag Coverage Δ *Carryforward flag
differential 18.47% <55.17%> (?)
total 15.27% <ø> (-0.02%) ⬇️ Carriedforward from f41d3fa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit 14e84ee into autowarefoundation:main Dec 11, 2023
31 of 35 checks passed
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
)

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-motion-utils-clang-tidy branch June 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants