Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module #5835

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Dec 11, 2023

Description

Add a new module to the behavior_velocity_planner for avoiding near collisions with dynamic obstacles.

Related links

JIRA ticket (TIER IV INTERNAL LINK): https://tier4.atlassian.net/browse/RT1-4471

Tests performed

PSim
Evaluator (TIER IV INTERNAL LINK):

Notes for reviewers

Launch PR: autowarefoundation/autoware_launch#730

Interface changes

New topics for the debug markers and virtual wall

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Dec 11, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Dec 11, 2023
@maxime-clem maxime-clem force-pushed the feat/dynamic_obstacle_stop branch from 010e9fe to 765449a Compare December 11, 2023 08:19
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 220 lines in your changes are missing coverage. Please review.

Comparison is base (2175b57) 15.29% compared to head (03d3674) 15.27%.
Report is 5 commits behind head on main.

Files Patch % Lines
...le_stop_module/src/scene_dynamic_obstacle_stop.cpp 0.00% 82 Missing ⚠️
...elocity_dynamic_obstacle_stop_module/src/debug.cpp 0.00% 39 Missing ⚠️
...ocity_dynamic_obstacle_stop_module/src/manager.cpp 0.00% 26 Missing ⚠️
...ity_dynamic_obstacle_stop_module/src/footprint.cpp 0.00% 25 Missing ⚠️
...amic_obstacle_stop_module/src/object_filtering.cpp 0.00% 25 Missing ⚠️
...ity_dynamic_obstacle_stop_module/src/collision.cpp 0.00% 18 Missing ⚠️
...elocity_dynamic_obstacle_stop_module/src/types.hpp 0.00% 3 Missing ⚠️
...ocity_dynamic_obstacle_stop_module/src/manager.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5835      +/-   ##
==========================================
- Coverage   15.29%   15.27%   -0.03%     
==========================================
  Files        1747     1755       +8     
  Lines      120123   120343     +220     
  Branches    36574    36574              
==========================================
  Hits        18377    18377              
- Misses      81129    81349     +220     
  Partials    20617    20617              
Flag Coverage Δ *Carryforward flag
differential 16.60% <0.00%> (?)
total 15.29% <ø> (ø) Carriedforward from 2175b57

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem force-pushed the feat/dynamic_obstacle_stop branch from 765449a to 786bdf3 Compare December 12, 2023 06:14
@maxime-clem maxime-clem added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Dec 12, 2023
@maxime-clem maxime-clem force-pushed the feat/dynamic_obstacle_stop branch from 786bdf3 to 73cdb31 Compare December 12, 2023 07:45
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem merged commit 2a6c16b into autowarefoundation:main Jan 10, 2024
21 of 25 checks passed
@maxime-clem maxime-clem deleted the feat/dynamic_obstacle_stop branch January 10, 2024 02:31
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Jan 11, 2024
…le (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Jan 11, 2024
…le (#1086)

feat(behavior_velocity_planner): add new 'dynamic_obstacle_stop' module (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…le (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…le (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…le (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…le (autowarefoundation#5835)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants