-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): fix missing parent ids #5838
fix(avoidance): fix missing parent ids #5838
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@@ -756,11 +756,21 @@ size_t findPathIndexFromArclength( | |||
std::vector<UUID> concatParentIds(const std::vector<UUID> & ids1, const std::vector<UUID> & ids2) | |||
{ | |||
std::vector<UUID> ret; | |||
for (const auto id2 : ids2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, if the ids2 is empty, return ids also becomes empty even if the ids1 is NOT empty.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5838 +/- ##
==========================================
+ Coverage 15.28% 15.29% +0.01%
==========================================
Files 1739 1739
Lines 119756 120182 +426
Branches 36369 36657 +288
==========================================
+ Hits 18301 18386 +85
- Misses 80976 81252 +276
- Partials 20479 20544 +65
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: karishma <karishma@interpl.ai>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
🤖[deprecated] Generated by Copilot at 43f5930
This pull request adds and improves the functionality of the
ShiftLineGenerator
class, which generates shifted lines that avoid obstacles and respect the lane boundaries. It assigns theparent_ids
field of the combined lines inshift_line_generator.cpp
and optimizes theconcatParentIds
function inutils.cpp
.Related Ticket: https://tier4.atlassian.net/browse/RT1-4532
Fix following error:
Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.