-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_loader): use dummy projector when using local coordinates #5866
feat(map_loader): use dummy projector when using local coordinates #5866
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I left one comment. Please check it out.
map/map_loader/src/lanelet2_map_loader/lanelet2_local_projector.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆♂️
@Motsu-san Please approve this PR as a codeowner 🙏 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
==========================================
- Coverage 15.33% 15.33% -0.01%
==========================================
Files 1742 1743 +1
Lines 119971 119987 +16
Branches 36486 36486
==========================================
Hits 18403 18403
- Misses 80978 80994 +16
Partials 20590 20590
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…utowarefoundation#5866) * feat(map_loader): use dummy projector when using local coordinates Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix build warning Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix runtime error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix reverse function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…utowarefoundation#5866) * feat(map_loader): use dummy projector when using local coordinates Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix build warning Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix runtime error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix reverse function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…utowarefoundation#5866) * feat(map_loader): use dummy projector when using local coordinates Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix build warning Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix runtime error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix reverse function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…utowarefoundation#5866) * feat(map_loader): use dummy projector when using local coordinates Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix build warning Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix runtime error Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> * fix reverse function Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> --------- Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Description
Close autowarefoundation/autoware#3427. Use dummy projector when using local coordinates. The dummy projector does no conversion calculations and always returns (0, 0, ele).
Related links
autowarefoundation/autoware#3427.
Tests performed
Check if the vehicle can drive autonomously in the simple planning simulator using local coordinate map.
Note: Since the tutorial map also has local coordinates, you can test it by adding the following file.
Notes for reviewers
None
Interface changes
None
Effects on system behavior
MRGS conversion is no longer performed when local projector type is selected.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.