Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): use dummy projector when using local coordinates #5866

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Dec 14, 2023

Description

Close autowarefoundation/autoware#3427. Use dummy projector when using local coordinates. The dummy projector does no conversion calculations and always returns (0, 0, ele).

Related links

autowarefoundation/autoware#3427.

Tests performed

Check if the vehicle can drive autonomously in the simple planning simulator using local coordinate map.
Note: Since the tutorial map also has local coordinates, you can test it by adding the following file.

# map_projector_info.yaml
projector_type: local

Notes for reviewers

None

Interface changes

None

Effects on system behavior

MRGS conversion is no longer performed when local projector type is selected.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Dec 14, 2023
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Dec 14, 2023
@isamu-takagi isamu-takagi marked this pull request as draft December 14, 2023 00:44
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi marked this pull request as ready for review December 14, 2023 02:29
@KYabuuchi KYabuuchi self-requested a review December 18, 2023 06:57
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I left one comment. Please check it out.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️

@KYabuuchi
Copy link
Contributor

@Motsu-san Please approve this PR as a codeowner 🙏

@isamu-takagi isamu-takagi enabled auto-merge (squash) December 20, 2023 02:56
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7477e9a) 15.33% compared to head (cb572e6) 15.33%.
Report is 46 commits behind head on main.

Files Patch % Lines
...c/lanelet2_map_loader/lanelet2_local_projector.hpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5866      +/-   ##
==========================================
- Coverage   15.33%   15.33%   -0.01%     
==========================================
  Files        1742     1743       +1     
  Lines      119971   119987      +16     
  Branches    36486    36486              
==========================================
  Hits        18403    18403              
- Misses      80978    80994      +16     
  Partials    20590    20590              
Flag Coverage Δ *Carryforward flag
differential 26.55% <0.00%> (?)
total 15.33% <ø> (+<0.01%) ⬆️ Carriedforward from 7477e9a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit ff609e2 into autowarefoundation:main Dec 20, 2023
32 of 35 checks passed
@isamu-takagi isamu-takagi deleted the feat/use-dummy-projector-when-using-local-coordinates branch December 21, 2023 01:01
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
…utowarefoundation#5866)

* feat(map_loader): use dummy projector when using local coordinates

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix build warning

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix runtime error

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix reverse function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5866)

* feat(map_loader): use dummy projector when using local coordinates

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix build warning

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix runtime error

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix reverse function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
…utowarefoundation#5866)

* feat(map_loader): use dummy projector when using local coordinates

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix build warning

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix runtime error

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix reverse function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#5866)

* feat(map_loader): use dummy projector when using local coordinates

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix build warning

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix runtime error

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix reverse function

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

---------

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to lanelet2_map_loader for local coordinates
3 participants