refactor(ndt_scan_matcher, map_loader): remove map_module #5873
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Large Method ndt_scan_matcher_core.cpp: is_activated_
- Complex Method pointcloud_map_loader_node.cpp: PointCloudMapLoaderNode::PointCloudMapLoaderNode
- Complex Conditional pointcloud_map_loader_node.cpp: PointCloudMapLoaderNode::PointCloudMapLoaderNode
Annotations
Check notice on line 297 in localization/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Large Method
is_activated_ decreases from 168 to 163 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 84 in map/map_loader/src/pointcloud_map_loader/pointcloud_map_loader_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
PointCloudMapLoaderNode::PointCloudMapLoaderNode is no longer above the threshold for cyclomatic complexity
Check notice on line 70 in map/map_loader/src/pointcloud_map_loader/pointcloud_map_loader_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
PointCloudMapLoaderNode::PointCloudMapLoaderNode no longer has a complex conditional