Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): potentially speed up cut overlapped lanes #5906

Merged

Conversation

danielsanchezaran
Copy link
Contributor

@danielsanchezaran danielsanchezaran commented Dec 19, 2023

Description

Potentially reduce processing time on CutOverlappedLanes by breaking early when finding the first path point within drivable lanes, also simplified a little the code by using a lambda function.

Related links

TIER IV Internal link: Evaluator tests for first commit (Currently running a new test, but in principle there is no degradation related to this change)

Tests performed

Ran evaluator (see above) and also tested on PSim if the overlapped lanes are cut correctly, the behavior is correct.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2023
@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 19, 2023
@danielsanchezaran danielsanchezaran marked this pull request as ready for review December 19, 2023 03:07
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d4d632a) 15.34% compared to head (11f05db) 15.21%.
Report is 34 commits behind head on main.

Files Patch % Lines
...s/drivable_area_expansion/static_drivable_area.cpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5906      +/-   ##
==========================================
- Coverage   15.34%   15.21%   -0.13%     
==========================================
  Files        1743     1762      +19     
  Lines      119952   122521    +2569     
  Branches    36481    37911    +1430     
==========================================
+ Hits        18402    18642     +240     
- Misses      80963    82915    +1952     
- Partials    20587    20964     +377     
Flag Coverage Δ *Carryforward flag
differential 11.73% <0.00%> (?)
total 15.34% <ø> (+<0.01%) ⬆️ Carriedforward from d4d632a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@satoshi-ota satoshi-ota merged commit df44938 into autowarefoundation:main Dec 20, 2023
32 of 35 checks passed
@satoshi-ota satoshi-ota deleted the feat/speed-up-cut-overlapped-lanes branch December 20, 2023 23:19
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
autowarefoundation#5906)

* Use a lambda and for_each to potentially reduce computation time

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* further simplify the code with lambda

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
autowarefoundation#5906)

* Use a lambda and for_each to potentially reduce computation time

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* further simplify the code with lambda

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
autowarefoundation#5906)

* Use a lambda and for_each to potentially reduce computation time

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* further simplify the code with lambda

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#5906)

* Use a lambda and for_each to potentially reduce computation time

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* further simplify the code with lambda

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
autowarefoundation#5906)

* Use a lambda and for_each to potentially reduce computation time

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

* further simplify the code with lambda

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>

---------

Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants