-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): potentially speed up cut overlapped lanes #5906
feat(behavior_path_planner): potentially speed up cut overlapped lanes #5906
Conversation
Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5906 +/- ##
==========================================
- Coverage 15.34% 15.21% -0.13%
==========================================
Files 1743 1762 +19
Lines 119952 122521 +2569
Branches 36481 37911 +1430
==========================================
+ Hits 18402 18642 +240
- Misses 80963 82915 +1952
- Partials 20587 20964 +377
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks!
autowarefoundation#5906) * Use a lambda and for_each to potentially reduce computation time Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * further simplify the code with lambda Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
autowarefoundation#5906) * Use a lambda and for_each to potentially reduce computation time Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * further simplify the code with lambda Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
autowarefoundation#5906) * Use a lambda and for_each to potentially reduce computation time Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * further simplify the code with lambda Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
autowarefoundation#5906) * Use a lambda and for_each to potentially reduce computation time Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * further simplify the code with lambda Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
autowarefoundation#5906) * Use a lambda and for_each to potentially reduce computation time Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * further simplify the code with lambda Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
Description
Potentially reduce processing time on CutOverlappedLanes by breaking early when finding the first path point within drivable lanes, also simplified a little the code by using a lambda function.
Related links
TIER IV Internal link: Evaluator tests for first commit (Currently running a new test, but in principle there is no degradation related to this change)
Tests performed
Ran evaluator (see above) and also tested on PSim if the overlapped lanes are cut correctly, the behavior is correct.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.