Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): publish steering factor from scene modules #5914

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Dec 19, 2023

Description

Fix a bug that scene modules does not publish steering_factor topics.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 19, 2023
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 19, 2023
@rej55 rej55 enabled auto-merge (squash) December 19, 2023 08:01
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7faeb91) 15.35% compared to head (eb03649) 15.35%.
Report is 9 commits behind head on main.

Files Patch % Lines
.../include/behavior_path_planner/planner_manager.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5914   +/-   ##
=======================================
  Coverage   15.35%   15.35%           
=======================================
  Files        1747     1747           
  Lines      120210   120208    -2     
  Branches    36631    36629    -2     
=======================================
  Hits        18461    18461           
  Misses      81074    81074           
+ Partials    20675    20673    -2     
Flag Coverage Δ *Carryforward flag
differential 9.42% <0.00%> (?)
total 15.35% <ø> (+<0.01%) ⬆️ Carriedforward from 7faeb91

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit bca290d into autowarefoundation:main Dec 20, 2023
30 of 32 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 20, 2023
autowarefoundation#5914)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
@rej55 rej55 deleted the fix/publish_steering_factor branch December 26, 2023 04:09
rej55 added a commit to tier4/autoware.universe that referenced this pull request Dec 26, 2023
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Mar 18, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
autowarefoundation#5914)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants