fix(start_planner): expand lane departure check for shift path #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
=======================================
Coverage 14.63% 14.63%
=======================================
Files 1858 1858
Lines 127063 127057 -6
Branches 37225 37225
=======================================
Hits 18590 18590
+ Misses 87577 87571 -6
Partials 20896 20896
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit 5d98bad
into
autowarefoundation:main
30 of 33 checks passed
This was referenced Jan 18, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: karishma <karishma@interpl.ai>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the lane departure check feature in start planner, checked section is shortened from shift end point with param of
collision_check_distance_from_end.But lane departure check should be applied for whole shifting section.
Tests performed
test with psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.